all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 36143-done@debbugs.gnu.org
Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c
Date: Sun, 09 Jun 2019 09:26:56 +0300	[thread overview]
Message-ID: <837e9vclzj.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmk9akXXeq7O_FrnmnWb_FKgvchEFHKSsiSzhZWA2LcQTw@mail.gmail.com> (message from Stefan Kangas on Sun, 9 Jun 2019 05:16:28 +0200)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Sun, 9 Jun 2019 05:16:28 +0200
> 
> Please see attached patch.

Thanks, I pushed it.

However, it looks like your local settings make Emacs untabify C
sources, so in your patch as posted a TAB was converted into spaces,
unlike the indentation around the line you changed (I fixed that
before committing).  Please in the future be sure to edit the Emacs
sources without such local settings; we only prefer spaces to TABs in
Lisp sources, see .dir-locals.el in the repository.





  reply	other threads:[~2019-06-09  6:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-09  3:16 bug#36143: [PATCH] Fix typo in src/keyboard.c Stefan Kangas
2019-06-09  6:26 ` Eli Zaretskii [this message]
2019-06-09  8:00   ` Stefan Kangas
     [not found] ` <handler.36143.D36143.156006163211770.notifdone@debbugs.gnu.org>
2019-06-09 13:20   ` bug#36143: [PATCH] Fix typo in src/keyboard.c) Noam Postavsky
2019-06-09 13:56     ` Eli Zaretskii
2019-06-09 14:07       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837e9vclzj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=36143-done@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.