From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37637: 27.0.50; Segmentation fault when setting font face for new frames Date: Tue, 08 Oct 2019 16:15:06 +0300 Message-ID: <837e5fxtt1.fsf@gnu.org> References: <878spxyjms.fsf@posteo.de> <83pnj92189.fsf@gnu.org> <877e5gxocp.fsf@posteo.de> <83pnj7y5hb.fsf@gnu.org> <616d6cd243f3c04026b32ac27b677425@posteo.de> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204561"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37637-done@debbugs.gnu.org To: Andreas Hilboll Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 08 15:16:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHpLv-000r6I-1Q for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 15:16:35 +0200 Original-Received: from localhost ([::1]:55528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHpLt-0005qg-AX for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 09:16:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39738) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHpLQ-0005qD-UK for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 09:16:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHpLP-00063b-VG for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 09:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40925) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHpLO-00061a-EP for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 09:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHpLO-0006xY-9i for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 09:16:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2019 13:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 37637 X-GNU-PR-Package: emacs Mail-Followup-To: 37637@debbugs.gnu.org, eliz@gnu.org, andreas.hilboll@posteo.de Original-Received: via spool by 37637-done@debbugs.gnu.org id=D37637.157054052224236 (code D ref 37637); Tue, 08 Oct 2019 13:16:01 +0000 Original-Received: (at 37637-done) by debbugs.gnu.org; 8 Oct 2019 13:15:22 +0000 Original-Received: from localhost ([127.0.0.1]:49745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHpKk-0006IT-BI for submit@debbugs.gnu.org; Tue, 08 Oct 2019 09:15:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHpKi-0006BO-Ie for 37637-done@debbugs.gnu.org; Tue, 08 Oct 2019 09:15:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iHpKd-0004w6-D3; Tue, 08 Oct 2019 09:15:15 -0400 Original-Received: from [176.228.60.248] (port=3301 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iHpKc-0005rG-1Z; Tue, 08 Oct 2019 09:15:14 -0400 In-reply-to: <616d6cd243f3c04026b32ac27b677425@posteo.de> (message from Andreas Hilboll on Tue, 08 Oct 2019 14:56:58 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168649 Archived-At: > Date: Tue, 08 Oct 2019 14:56:58 +0200 > From: Andreas Hilboll > > > diff --git a/src/font.c b/src/font.c > > index 935dd64..044c437 100644 > > --- a/src/font.c > > +++ b/src/font.c > > @@ -3314,6 +3314,9 @@ font_open_for_lface (struct frame *f, > > Lisp_Object entity, Lisp_Object *attrs, Li > > pt = XFIXNUM (attrs[LFACE_HEIGHT_INDEX]); > > else > > { > > + /* We need the default face to be valid below. */ > > + if (FRAME_FACE_CACHE (f)->used == 0) > > + recompute_basic_faces (f); > > struct face *def = FACE_FROM_ID (f, DEFAULT_FACE_ID); > > Lisp_Object height = def->lface[LFACE_HEIGHT_INDEX]; > > eassert (FIXNUMP (height)); > > Great, this seems to fix it. Works without problems now (after opening > ~10 new frames without any crash I stopped ...). Thanks, pushed to the master branch, and closing the bug report.