all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Hilboll <andreas.hilboll@posteo.de>
Cc: 37637-done@debbugs.gnu.org
Subject: bug#37637: 27.0.50; Segmentation fault when setting font face for new frames
Date: Tue, 08 Oct 2019 16:15:06 +0300	[thread overview]
Message-ID: <837e5fxtt1.fsf@gnu.org> (raw)
In-Reply-To: <616d6cd243f3c04026b32ac27b677425@posteo.de> (message from Andreas Hilboll on Tue, 08 Oct 2019 14:56:58 +0200)

> Date: Tue, 08 Oct 2019 14:56:58 +0200
> From: Andreas Hilboll <andreas.hilboll@posteo.de>
> 
> > diff --git a/src/font.c b/src/font.c
> > index 935dd64..044c437 100644
> > --- a/src/font.c
> > +++ b/src/font.c
> > @@ -3314,6 +3314,9 @@ font_open_for_lface (struct frame *f,
> > Lisp_Object entity, Lisp_Object *attrs, Li
> >  	    pt = XFIXNUM (attrs[LFACE_HEIGHT_INDEX]);
> >  	  else
> >  	    {
> > +	      /* We need the default face to be valid below.  */
> > +	      if (FRAME_FACE_CACHE (f)->used == 0)
> > +		recompute_basic_faces (f);
> >  	      struct face *def = FACE_FROM_ID (f, DEFAULT_FACE_ID);
> >  	      Lisp_Object height = def->lface[LFACE_HEIGHT_INDEX];
> >  	      eassert (FIXNUMP (height));
> 
> Great, this seems to fix it.  Works without problems now (after opening 
> ~10 new frames without any crash I stopped ...).

Thanks, pushed to the master branch, and closing the bug report.





      reply	other threads:[~2019-10-08 13:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-06 15:32 bug#37637: 27.0.50; Segmentation fault when setting font face for new frames Andreas Hilboll
2019-10-06 18:11 ` Eli Zaretskii
2019-10-07 21:00   ` Andreas Hilboll
2019-10-08  9:02     ` Eli Zaretskii
2019-10-08 12:56       ` Andreas Hilboll
2019-10-08 13:15         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837e5fxtt1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37637-done@debbugs.gnu.org \
    --cc=andreas.hilboll@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.