From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: jonas@bernoul.li, emacs-devel@gnu.org
Subject: Re: Let mode-line packages distinguish the selected-window
Date: Sun, 27 Oct 2019 07:01:28 +0200 [thread overview]
Message-ID: <837e4qu6hj.fsf@gnu.org> (raw)
In-Reply-To: <9a34b0c1-149b-a850-db88-b9d7cb5c751e@gmx.at> (message from martin rudalics on Sat, 26 Oct 2019 23:10:53 +0200)
> Cc: emacs-devel@gnu.org
> From: martin rudalics <rudalics@gmx.at>
> Date: Sat, 26 Oct 2019 23:10:53 +0200
>
> (or (eq (selected-window) (old-selected-window))
> (and (not (zerop (minibuffer-depth)))
> (eq (selected-window)
> (with-selected-window (minibuffer-window)
> (minibuffer-selected-window)))))
>
> should handle all concerns. To get rid of the 'with-selected-window'
> 'minibuffer-selected-window' should accept an optional argument in
> order to skip the
>
> && MINI_WINDOW_P (XWINDOW (selected_window))
>
> check.
If we are going to add this feature as a C primitive, it should
ideally free the Lisp programmers from jumping through any additional
hoops, IMO. So the above should be done in C instead, before
returning the value. If some applications may want the minibuffer
window and others won't, we should make the function accept an
optional argument to select between these two alternatives.
next prev parent reply other threads:[~2019-10-27 5:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 13:38 Let mode-line packages distinguish the selected-window Jonas Bernoulli
2019-10-26 14:01 ` Eli Zaretskii
2019-10-26 21:10 ` martin rudalics
2019-10-27 5:01 ` Eli Zaretskii [this message]
2019-10-27 7:48 ` martin rudalics
2019-10-27 21:13 ` Jonas Bernoulli
2019-10-28 9:40 ` martin rudalics
2019-10-28 10:32 ` Jonas Bernoulli
2019-10-29 9:27 ` martin rudalics
2019-10-29 12:24 ` Eli Zaretskii
2019-10-29 18:05 ` martin rudalics
2019-10-29 18:46 ` Eli Zaretskii
2019-10-30 8:14 ` martin rudalics
2019-10-30 16:10 ` Eli Zaretskii
2019-10-28 15:55 ` Eli Zaretskii
2019-10-29 11:50 ` Jonas Bernoulli
2019-10-26 16:36 ` Stefan Monnier
2019-10-26 19:27 ` Jonas Bernoulli
2019-10-26 19:41 ` Eli Zaretskii
2019-10-26 20:36 ` Stefan Monnier
2019-10-27 18:08 ` Jonas Bernoulli
2019-10-27 21:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837e4qu6hj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jonas@bernoul.li \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.