From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38424: [PATCH] Add new filter functions to Package Menu Date: Sat, 30 Nov 2019 14:18:12 +0200 Message-ID: <837e3ho8vv.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="147749"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38424@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 30 13:19:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ib1iR-000cFm-3H for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Nov 2019 13:19:11 +0100 Original-Received: from localhost ([::1]:39926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ib1iP-0005rl-7j for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Nov 2019 07:19:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52008) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ib1iJ-0005rc-2O for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 07:19:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ib1iI-0001gY-1K for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 07:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ib1iH-0001gU-UL for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 07:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ib1iH-0004vK-Qm for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 07:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2019 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38424 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38424-submit@debbugs.gnu.org id=B38424.157511631418854 (code B ref 38424); Sat, 30 Nov 2019 12:19:01 +0000 Original-Received: (at 38424) by debbugs.gnu.org; 30 Nov 2019 12:18:34 +0000 Original-Received: from localhost ([127.0.0.1]:33827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ib1hq-0004u2-AQ for submit@debbugs.gnu.org; Sat, 30 Nov 2019 07:18:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ib1ho-0004tn-69 for 38424@debbugs.gnu.org; Sat, 30 Nov 2019 07:18:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ib1hh-0001NW-Pa; Sat, 30 Nov 2019 07:18:26 -0500 Original-Received: from [176.228.60.248] (port=4826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ib1hh-00080k-7u; Sat, 30 Nov 2019 07:18:25 -0500 In-reply-to: (message from Stefan Kangas on Fri, 29 Nov 2019 13:31:10 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172682 Archived-At: > From: Stefan Kangas > Date: Fri, 29 Nov 2019 13:31:10 +0100 > > The attached patches adds new commands to filter the "*Packages*" > buffer by version, status and archive. (The first patch only adds new > version list comparison predicates, something I needed to simplify the > second patch.) We deliberately didn't define the functions you are now adding, since they are just one 'not' away. Do they really simplify the callers so much that we now want to add them? > * doc/emacs/package.texi (Package Menu): Document it. This tells nothing about the changes which aren't "documenting it". (And, btw, what is "it" here is not clear at all.) > - (when (or (eq packages t) (memq name packages)) > + (when (or (not packages) (memq name packages)) > (dolist (pkg (cdr elt)) > (when (package--has-keyword-p pkg keywords) > (push pkg info-list)))))) > @@ -2950,7 +2958,7 @@ package-menu--refresh > (when (and (package--has-keyword-p pkg keywords) > (or package-list-unversioned > (package--bi-desc-version (cdr elt))) > - (or (eq packages t) (memq name packages))) > + (or (not packages) (memq name packages))) > (push pkg info-list))))) > > ;; Available and disabled packages: > @@ -2959,7 +2967,7 @@ package-menu--refresh > (dolist (elt package-archive-contents) > (let ((name (car elt))) > ;; To be displayed it must be in PACKAGES; > - (when (and (or (eq packages t) (memq name packages)) > + (when (and (or (not packages) (memq name packages)) Does the above mean you are suggesting a backward-incompatible API change? > +Arguments PACKAGES and KEYWORDS are like `package-menu--refresh'." Arguments cannot be "like" a function. Suggest to say "like in `package-menu--refresh'" instead. I don't use package.el, so I'd like someone who does or knows the code well to review the patch. Thanks.