From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: GDI+ take 3 Date: Tue, 14 Apr 2020 18:33:59 +0300 Message-ID: <837dyihyjc.fsf@gnu.org> References: <86h7xzc5ai.fsf@csic.es> <83d08mt7gy.fsf@gnu.org> <83eesrkivc.fsf@gnu.org> <865ze3wvk8.fsf@csic.es> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="28006"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Juan =?utf-8?Q?Jos=C3=A9_Garc=C3=ADa-Ripoll?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 14 18:59:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOOuV-0007Ak-D6 for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 18:59:43 +0200 Original-Received: from localhost ([::1]:35288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOuU-0003ya-DA for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 12:59:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60432) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOiF-0000xl-M4 for emacs-devel@gnu.org; Tue, 14 Apr 2020 12:47:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jONZs-0002K4-54; Tue, 14 Apr 2020 11:34:20 -0400 Original-Received: from [176.228.60.248] (port=3083 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jONZr-0005Sx-Iz; Tue, 14 Apr 2020 11:34:19 -0400 In-Reply-To: <865ze3wvk8.fsf@csic.es> (juanjose.garciaripoll@gmail.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246949 Archived-At: > From: Juan José García-Ripoll > > Date: Mon, 13 Apr 2020 12:04:39 +0200 > > Eli Zaretskii writes: > > I'd like to install these changes, but some parts seem to be missing, > > see above. Could you please post the missing parts (or the entire > > changeset, if that is more convenient)? > > Apologies for the corrupted patch. Here it goes, I hope, in a complete form. Thanks, I've installed this now on the master branch, with some changes to enable switching this feature on and off at runtime. Building with this feature available is now ON by default, but to actually use the feature, one needs to turn it on at runtime by setting the new variable w32-use-native-image-API to a non-nil value. There's a FIXME in w32image.c: in my testing the call to GdipImageGetFrameCount in w32_select_active_frame always fails with status Win32Err, I couldn't understand why. Did I goof with some of my changes on top of yours? For now, I simply disregarded that particular error; the code seems to work fine otherwise (but multiframe images will probably not work as expected). Could you please look into this and see what could be causing this? There's another FIXME in w32image.c that asks about including the objidl.h header. I didn't need that in my mingw.org's MinGW build, but maybe MinGW64 builds do. Testing and bug reports about this new feature are welcome. Thanks again for working on this and for persevering.