From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition
Date: Fri, 26 Jun 2020 13:46:52 +0300
Message-ID: <837dvurtnn.fsf@gnu.org>
References: <m1mu4qg6s4.fsf@eidolon.muppetlabs.com>
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="41134"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Mike Hamrick <mikeh@muppetlabs.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 26 12:47:40 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1joltU-000AbE-OI
	for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Jun 2020 12:47:40 +0200
Original-Received: from localhost ([::1]:38366 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1joltT-0004qa-Pg
	for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Jun 2020 06:47:39 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44686)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1jolt0-0004Rd-N8
 for emacs-devel@gnu.org; Fri, 26 Jun 2020 06:47:10 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60582)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jolt0-0001vx-15; Fri, 26 Jun 2020 06:47:10 -0400
Original-Received: from [176.228.60.248] (port=1380 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jolsz-0001nn-BF; Fri, 26 Jun 2020 06:47:09 -0400
In-Reply-To: <m1mu4qg6s4.fsf@eidolon.muppetlabs.com> (message from Mike
 Hamrick on Thu, 25 Jun 2020 14:44:11 -0700)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:252538
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/252538>

> From: Mike Hamrick <mikeh@muppetlabs.com>
> Date: Thu, 25 Jun 2020 14:44:11 -0700
> 
> Here is my patch which adds Emacs TTY support for strike-through
> rendering, which I personally use in org-mode for done TODO items. In
> order for this to work for you, your terminfo database entry needs to have the
> "smxx" capability defined, which I believe more recent versions[0] of the
> xterm entry have.
> 
> [0]: https://invisible-island.net/xterm/terminfo.html

Thanks.  The changes look good to me, but:

 . please add a NEWS item announcing the support for this face
   attribute
 . the changes are large enough to require you to sign a copyright
   assignment for them; if you agree to start your legal paperwork, I
   will send you the form to fill

Thank you for your interest in Emacs.