From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Date: Fri, 11 Sep 2020 08:59:04 +0300 Message-ID: <837dt0j1lj.fsf@gnu.org> References: <87o8mdzds8.fsf@gmail.com> <87wo114acc.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43315@debbugs.gnu.org, caiohcs0@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 11 08:00:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGc6S-0001ZQ-UG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Sep 2020 08:00:08 +0200 Original-Received: from localhost ([::1]:45888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGc6S-0003mN-0B for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Sep 2020 02:00:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGc6M-0003mH-AC for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 02:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGc6L-0006tQ-V3 for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 02:00:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGc6L-0006rd-T9 for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 02:00:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Sep 2020 06:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 43315-submit@debbugs.gnu.org id=B43315.159980394726298 (code B ref 43315); Fri, 11 Sep 2020 06:00:01 +0000 Original-Received: (at 43315) by debbugs.gnu.org; 11 Sep 2020 05:59:07 +0000 Original-Received: from localhost ([127.0.0.1]:42101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGc5S-0006q6-JC for submit@debbugs.gnu.org; Fri, 11 Sep 2020 01:59:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGc5Q-0006pc-S8 for 43315@debbugs.gnu.org; Fri, 11 Sep 2020 01:59:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGc5L-0006ou-E4; Fri, 11 Sep 2020 01:58:59 -0400 Original-Received: from [176.228.60.248] (port=1097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kGc5K-0007Df-5x; Fri, 11 Sep 2020 01:58:58 -0400 In-Reply-To: <87wo114acc.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 10 Sep 2020 22:59:15 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187791 Archived-At: > Resent-From: Lars Ingebrigtsen > Original-Sender: "Debbugs-submit" > Resent-CC: bug-gnu-emacs@gnu.org > Resent-Sender: help-debbugs@gnu.org > From: Lars Ingebrigtsen > Date: Thu, 10 Sep 2020 22:59:15 +0200 > Cc: 43315@debbugs.gnu.org > > Caio Henrique writes: > > > Here is my proposal: > > I'm not used to the default undo system since I use undo-tree, but it > > seems that Emacs 28 has added a function called undo-redo to the > > simple.el file, right? My proposal is to add it to the menu-bar, right > > bellow "Undo": > > Makes sense to me, so I've applied your patch to Emacs 28. Thanks. However, when we put a command on a menu item, we should make sure its documentation is clear enough for newbies. In this case, the doc string was so terse it was beyond obscure, and needed fixing to be clear enough for a menu command. (I fixed it.)