From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Date: Thu, 18 Mar 2021 16:30:43 +0200 Message-ID: <837dm4h6uk.fsf@gnu.org> References: <87zgz0wpe7.fsf@tcd.ie> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24367"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47234@debbugs.gnu.org, juri@linkov.net To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 15:31:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMtg7-0006FV-7P for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 15:31:11 +0100 Original-Received: from localhost ([::1]:33414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMtg6-0004Fj-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 10:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMtfy-0004E9-M2 for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMtfy-0005Lu-ED for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMtfy-0007xn-Av for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47234 X-GNU-PR-Package: emacs Original-Received: via spool by 47234-submit@debbugs.gnu.org id=B47234.161607785630600 (code B ref 47234); Thu, 18 Mar 2021 14:31:02 +0000 Original-Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 14:30:56 +0000 Original-Received: from localhost ([127.0.0.1]:47664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMtfs-0007xU-EQ for submit@debbugs.gnu.org; Thu, 18 Mar 2021 10:30:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMtfq-0007xH-NC for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 10:30:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56115) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMtfk-0005AI-D8; Thu, 18 Mar 2021 10:30:48 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3160 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMtfj-00041O-B2; Thu, 18 Mar 2021 10:30:47 -0400 In-Reply-To: <87zgz0wpe7.fsf@tcd.ie> (contovob@tcd.ie) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202599 Archived-At: > From: "Basil L. Contovounesios" > Date: Thu, 18 Mar 2021 13:41:04 +0000 > Cc: juri linkov > > In a build --without-x: > > 0. ./src/emacs -Q > 1. (frame-inner-height) C-j > > Debugger entered--Lisp error: (void-function tab-bar-height) > tab-bar-height(# t) > frame-inner-height() > (progn (frame-inner-height)) > eval((progn (frame-inner-height)) t) > elisp--eval-last-sexp(t) > eval-last-sexp(t) > eval-print-last-sexp(nil) > funcall-interactively(eval-print-last-sexp nil) > call-interactively(eval-print-last-sexp nil nil) > command-execute(eval-print-last-sexp) > > The obvious band-aid is to check (fboundp 'tab-bar-height) in > frame-inner-height, but shouldn't we count 1 line when tab-bar-mode is > enabled even --without-x? IOW, can/should tab-bar-height or similar be > defined regardless of HAVE_WINDOW_SYSTEM? What's TRT here? TRT is to teach Emacs to return the tab-bar height on TTY frames as well. But I don't think defining tab-bar-height on TTY frames is the right way: the tab-bar is always 1 line high on those frames, so we could simply use that hardcoded value instead of signaling an error, I think.