From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 07/15] Add BVAR_OR_DEFAULT macro as a stub Date: Fri, 07 May 2021 13:54:15 +0300 Message-ID: <837dkaddbc.fsf@gnu.org> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-8-sbaugh@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19778"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 12:55:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ley8k-00053N-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 12:55:26 +0200 Original-Received: from localhost ([::1]:51548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ley8j-00047f-Th for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 06:55:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ley8P-00047W-0h for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 06:55:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ley8M-0002XD-G4 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 06:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ley8M-00037A-EG for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 06:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162038487211947 (code B ref 48264); Fri, 07 May 2021 10:55:02 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 10:54:32 +0000 Original-Received: from localhost ([127.0.0.1]:43152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ley7s-00036d-As for submit@debbugs.gnu.org; Fri, 07 May 2021 06:54:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ley7q-00036X-Ox for 48264@debbugs.gnu.org; Fri, 07 May 2021 06:54:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33226) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ley7l-0002Ag-Cb; Fri, 07 May 2021 06:54:25 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2113 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1ley7k-00073f-Vh; Fri, 07 May 2021 06:54:25 -0400 In-Reply-To: <20210506213346.9730-8-sbaugh@catern.com> (message from Spencer Baugh on Thu, 6 May 2021 17:33:38 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205914 Archived-At: > From: Spencer Baugh > Date: Thu, 6 May 2021 17:33:38 -0400 > Cc: Spencer Baugh > > For buffer variables without a default, we still use BVAR. For any > buffer variable with a default, we use BVAR_OR_DEFAULT. A later > commit will statically enforce this. This part says they are the same: > --- a/src/buffer.h > +++ b/src/buffer.h > @@ -284,6 +284,8 @@ struct buffer_text > > #define BVAR(buf, field) ((buf)->field ## _) > > +#define BVAR_OR_DEFAULT(buf, field) BVAR (buf, field) What am I missing here? Also, I have a question: suppose we have a variable that is defined with DEFVAR_LISP, and then some Lisp calls make-variable-buffer-local: how will that work with these two macros when the C code needs to access the buffer-local value?