From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51049: 28.0.50; tool-bar :vert-only property is broken, not documented and of limited use Date: Wed, 06 Oct 2021 19:32:54 +0300 Message-ID: <837deq2jwp.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22704"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51049@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 06 18:34:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY9s2-0005eX-Im for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 18:34:18 +0200 Original-Received: from localhost ([::1]:55360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY9s1-00026M-1I for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 12:34:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY9rm-00021n-Pk for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 12:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mY9rm-000596-DQ for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 12:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mY9rl-0007B0-Ly for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 12:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Oct 2021 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51049 X-GNU-PR-Package: emacs Original-Received: via spool by 51049-submit@debbugs.gnu.org id=B51049.163353799127524 (code B ref 51049); Wed, 06 Oct 2021 16:34:01 +0000 Original-Received: (at 51049) by debbugs.gnu.org; 6 Oct 2021 16:33:11 +0000 Original-Received: from localhost ([127.0.0.1]:45367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY9qx-00079s-Bp for submit@debbugs.gnu.org; Wed, 06 Oct 2021 12:33:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY9qu-00079a-Hs for 51049@debbugs.gnu.org; Wed, 06 Oct 2021 12:33:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32810) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY9qp-0004KY-1o; Wed, 06 Oct 2021 12:33:03 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4984 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY9qo-0003Ua-Ka; Wed, 06 Oct 2021 12:33:02 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 5 Oct 2021 19:57:51 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216571 Archived-At: > From: Stefan Kangas > Date: Tue, 5 Oct 2021 19:57:51 -0400 > > According to commit d2bd51898e4 the :vert-only property for toolbar > items is supposed to be "for tool bar items with labels not shown > horizontally". > > These properties are used in some places in our sources, but are not > documented in (info "(elisp) Tool Bar"). > > They also don't seem to be working, at least not in GTK: > > 0. emacs -Q > 1. (custom-set-variables '(tool-bar-position 'left)) > 2. M-x mpc RET > > (Note that the entire tool-bar in mpc.el has the :vert-only property.) I suggest to step with a debugger into update_frame_tool_bar in gtkutil.c, where this is implemented, and see what's going on there. The effect of :vert-only is conditioned on other aspects of the tool bar and its buttons, so it could be that what you see is the feature working as designed, and you just didn't create the conditions for it to have the effect. Jan Djärv, who implemented that, was our X and GTK expert, so it is hard for me to believe that the code didn't work at least then (it could have bit-rotten with the newer versions of GTK, of course). > I also do wonder if this property is at all useful. If anything, I > would like the option to *hide* labels in horizontal mode, as having > labels makes the toolbar change size when I switch between windows to > with different major modes. It's fine to introduce new features, but why remove old ones while at that? What is not useful to you could be useful to someone else. > So should the :vert-only property be documented? Fixed? Removed? Documented, probably -- but then :label should also be documented. Fixed? not sure what to fix. Removed? definitely no.