From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50993: 29.0.50; Problems when dragging the mouse over the toolbar Date: Tue, 12 Oct 2021 17:01:51 +0300 Message-ID: <837deiqr3k.fsf@gnu.org> References: <87r1d2b9e2.fsf.ref@yahoo.com> <87r1d2b9e2.fsf@yahoo.com> <83y270rd4j.fsf@gnu.org> <83lf30r8eq.fsf@gnu.org> <877dekcsc1.fsf@yahoo.com> <87ily4aur8.fsf@yahoo.com> <44097514-26fb-fe2f-fb82-cfb819f13d2a@gmx.at> <87k0ijalp8.fsf@yahoo.com> <878ryzafqk.fsf@yahoo.com> <87wnmj85o2.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2627"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 50993@debbugs.gnu.org, monnier@iro.umontreal.ca To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 12 16:04:05 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maINx-0000Q9-FM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Oct 2021 16:04:05 +0200 Original-Received: from localhost ([::1]:55520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maINv-0000MD-2p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Oct 2021 10:04:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maIMw-0000IL-MF for bug-gnu-emacs@gnu.org; Tue, 12 Oct 2021 10:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maIMw-0001gA-EN for bug-gnu-emacs@gnu.org; Tue, 12 Oct 2021 10:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maIMw-0000SP-Bm for bug-gnu-emacs@gnu.org; Tue, 12 Oct 2021 10:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Oct 2021 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50993 X-GNU-PR-Package: emacs Original-Received: via spool by 50993-submit@debbugs.gnu.org id=B50993.16340473291615 (code B ref 50993); Tue, 12 Oct 2021 14:03:02 +0000 Original-Received: (at 50993) by debbugs.gnu.org; 12 Oct 2021 14:02:09 +0000 Original-Received: from localhost ([127.0.0.1]:42884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maIM5-0000Pz-0Z for submit@debbugs.gnu.org; Tue, 12 Oct 2021 10:02:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maIM3-0000PG-2r for 50993@debbugs.gnu.org; Tue, 12 Oct 2021 10:02:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40486) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maILw-000136-CA; Tue, 12 Oct 2021 10:02:00 -0400 Original-Received: from [87.69.77.57] (port=3583 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maILu-0007cU-Eo; Tue, 12 Oct 2021 10:01:59 -0400 In-Reply-To: (message from martin rudalics on Tue, 12 Oct 2021 10:12:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217034 Archived-At: > Cc: Stefan Monnier , Eli Zaretskii , > 50993@debbugs.gnu.org > From: martin rudalics > Date: Tue, 12 Oct 2021 10:12:01 +0200 > > >> diff --git a/src/keyboard.c b/src/keyboard.c > >> index bc6f97586d..ba625c4f77 100644 > >> --- a/src/keyboard.c > >> +++ b/src/keyboard.c > >> @@ -5122,7 +5122,8 @@ make_lispy_position (struct frame *f, Lisp_Object x, Lisp_Object y, > >> #endif > >> ) > >> { > >> - posn = EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar; > >> + if (NILP (track_mouse)) > >> + posn = EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar; > >> /* Kludge alert: for mouse events on the tab bar and tool bar, > >> keyboard.c wants the frame, not the special-purpose window > >> we use to display those, and it wants frame-relative > > > > This seems to work. > > If nobody objects I'll push this to Emacs 28 in the next days. Rationale? It means no mouse movement on the tool bar or tab bar will ever be reported as such.