From: Eli Zaretskii <eliz@gnu.org>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: 51766@debbugs.gnu.org
Subject: bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods
Date: Thu, 11 Nov 2021 17:19:15 +0200 [thread overview]
Message-ID: <837dde200c.fsf@gnu.org> (raw)
In-Reply-To: <87mtmalrs1.fsf@localhost> (message from Ihor Radchenko on Thu, 11 Nov 2021 21:56:46 +0800)
> From: Ihor Radchenko <yantar92@gmail.com>
> Date: Thu, 11 Nov 2021 21:56:46 +0800
>
> According to buffer-chars-modified-tick docstring:
> "By comparing the values returned by two individual calls of
> buffer-chars-modified-tick, you can tell whether a character change
> occurred in that buffer in between these calls"
>
> However, the return value can change even when no visible change is made
> to buffer text.
>
> Steps to reproduce:
> 1. emacs -Q
> 2. Evaluate the following code:
>
> (defun print-tick-before ()
> (when (eq this-command 'self-insert-command)
> (warn "Tick before: %S" (buffer-chars-modified-tick))))
> (defun print-tick-after ()
> (when (eq this-command 'self-insert-command)
> (warn "Tick after: %S" (buffer-chars-modified-tick))))
> (add-hook 'pre-command-hook #'print-tick-before)
> (add-hook 'post-command-hook #'print-tick-after)
>
> 3. Insert a latin symbol ?a twice. The warning buffer will print
> something like
>
> Warning (emacs): Tick before: 1698 Disable showing Disable logging
> Warning (emacs): Tick after: 1699 Disable showing Disable logging
> Warning (emacs): Tick before: 1699 Disable showing Disable logging
> Warning (emacs): Tick after: 1702 Disable showing Disable logging
>
> Note that second and third line show the same buffer-chars-modified-tick
> value.
>
> 4. Change input method (C-\) to russian-computer or i.e. arabic
> 5. Insert a non-latin symbol ?ф twice. The warning buffer will print
> something like
>
> Warning (emacs): Tick before: 1706 Disable showing Disable logging
> Warning (emacs): Tick after: 1707 Disable showing Disable logging
> Warning (emacs): Tick before: 1711 Disable showing Disable logging
> Warning (emacs): Tick after: 1712 Disable showing Disable logging
>
> Note that second and third line _do not_ show the same
> buffer-chars-modified-tick value even though buffer text has not been
> changed between the two self-insert commands
>
> Expected behaviour: return value of buffer-chars-modified-tick does not
> change when no changes in buffer text are made.
How do you know there was no changes in the buffer? You call your
function from pre/post-command-hook, but why is it guaranteed that
there was no change in the buffer between post-command-hook and the
following pre-command-hook?
next prev parent reply other threads:[~2021-11-11 15:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 13:56 bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods Ihor Radchenko
2021-11-11 15:19 ` Eli Zaretskii [this message]
2021-11-11 15:50 ` Ihor Radchenko
2021-11-11 17:35 ` Eli Zaretskii
2021-11-12 12:06 ` Ihor Radchenko
2021-11-12 12:15 ` Eli Zaretskii
2021-11-12 12:53 ` Ihor Radchenko
2021-11-12 13:09 ` Eli Zaretskii
2021-11-12 13:39 ` Ihor Radchenko
2021-11-12 15:17 ` Eli Zaretskii
2021-11-13 9:10 ` Ihor Radchenko
2021-11-13 10:11 ` Eli Zaretskii
2021-11-13 11:29 ` Ihor Radchenko
2021-11-13 13:38 ` Eli Zaretskii
2021-11-13 14:43 ` Ihor Radchenko
2021-11-13 15:24 ` Eli Zaretskii
2022-06-17 2:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 5:36 ` Eli Zaretskii
2022-06-17 13:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 10:05 ` Ihor Radchenko
2022-06-17 10:50 ` Eli Zaretskii
2022-06-21 4:13 ` bug#51766: string-pixel-width limitations (was: bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods) Ihor Radchenko
2022-06-21 10:16 ` Eli Zaretskii
2022-06-21 11:00 ` Ihor Radchenko
2022-06-21 12:17 ` Eli Zaretskii
2022-06-21 12:39 ` Ihor Radchenko
2022-06-21 12:47 ` Eli Zaretskii
2022-06-21 13:03 ` Ihor Radchenko
2022-06-22 23:49 ` bug#51766: string-pixel-width limitations Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 13:28 ` bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-21 4:14 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dde200c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51766@debbugs.gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.