From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51716: 29.0.50; [PATCH] Expose xwidget navigation history to Lisp code Date: Sun, 14 Nov 2021 09:20:01 +0200 Message-ID: <837ddbw6e6.fsf@gnu.org> References: <871r3p8r05.fsf.ref@yahoo.com> <871r3p8r05.fsf@yahoo.com> <83o86s2ft8.fsf@gnu.org> <874k8j33mw.fsf@yahoo.com> <83czn4xfnu.fsf@gnu.org> <87pmr3mvxc.fsf@yahoo.com> <83fsrzw7lz.fsf@gnu.org> <87k0hb9qbg.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23565"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 51716@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 14 08:21:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mm9pS-0005wT-QU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 08:21:30 +0100 Original-Received: from localhost ([::1]:57076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mm9pR-0007FI-Q9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 02:21:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mm9p0-0007CM-4e for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 02:21:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mm9oz-0004eI-Se for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 02:21:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mm9oz-00089g-P5 for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 02:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Nov 2021 07:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51716-submit@debbugs.gnu.org id=B51716.163687442231260 (code B ref 51716); Sun, 14 Nov 2021 07:21:01 +0000 Original-Received: (at 51716) by debbugs.gnu.org; 14 Nov 2021 07:20:22 +0000 Original-Received: from localhost ([127.0.0.1]:49014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mm9oL-000888-Rb for submit@debbugs.gnu.org; Sun, 14 Nov 2021 02:20:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mm9oJ-00087p-Uw for 51716@debbugs.gnu.org; Sun, 14 Nov 2021 02:20:20 -0500 Original-Received: from [2001:470:142:3::e] (port=45490 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mm9oE-0004Rb-Oe; Sun, 14 Nov 2021 02:20:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/9SvUkpfiFnorH4Fq80xoFqIfWuq5P/uI1A1p3J/uBU=; b=GBwrs52Xvo3W 1QsEcZp8dvF4GjNCxq4Pa7HIG0g7ZcZMFpD42zO0ee0ea5j4yBHXOTvgIptGFTDl3BWxcTr1+B1BG pvstscoaziDrFqo5SQHR2/kLvzarvkiL7oH/FxcN9IRoqGhwdKSHaSjPMlz2492Z5GkpAOqLBlW0v nMniP+5m1jU1H8reSBPWj137+8yx6mQhAxVqPKyrC+Ty4TZ67FKPtWn/DKmD/crbC4hyHoDp/8jB1 0ndLXol1RT2h8UhD2qolkQwE1QNvNmujM5a75oVj9jUJTXVI5xbPe7Q3Fh1Nx/DemStOIr3ZSM0CR 4fCmCnkQbkEEnnHyD7sFSQ==; Original-Received: from [87.69.77.57] (port=4863 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mm9oE-0006go-DY; Sun, 14 Nov 2021 02:20:14 -0500 In-Reply-To: <87k0hb9qbg.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 14 Nov 2021 07:58:11 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219902 Archived-At: > From: Lars Ingebrigtsen > Cc: Po Lu , 51716@debbugs.gnu.org > Date: Sun, 14 Nov 2021 07:58:11 +0100 > > Eli Zaretskii writes: > > > If they cannot include invalid UTF-8, then using decode_string_utf_8 > > is what you need to do. You cannot use those strings directly in > > Lisp, because they will be unibyte strings. IOW, using build_string > > there is incorrect, you need to use make_unibyte_string and > > decode_string_utf_8 instead. build_string is correct only for > > plain-ASCII strings. > > Can't he use make_multibyte_string instead? I'd rather not. Code which uses external strings without decoding looks wrong, and the time it takes to convince yourself it does TRT (if it does) is time lost. decode_string_utf_8 is very fast, and xwidgets aren't supposed to be in the inner loops of Emacs. So I see no reason for shortcuts here.