From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Fri, 04 Mar 2022 15:33:02 +0200 Message-ID: <837d99j10x.fsf@gnu.org> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> <83czj2hrdv.fsf@gnu.org> <87a6e5lui6.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38978"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kfogel@red-bean.com, emacs-devel@gnu.org To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 04 14:48:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ8IA-0009wE-IB for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 14:48:22 +0100 Original-Received: from localhost ([::1]:45626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ8I9-0006Bx-5c for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 08:48:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ83K-0000sx-N0 for emacs-devel@gnu.org; Fri, 04 Mar 2022 08:33:03 -0500 Original-Received: from [2001:470:142:3::e] (port=44618 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ83J-0007zJ-Uw; Fri, 04 Mar 2022 08:33:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0bihu1gT4wlMAaqCiUmyWH4b3KOBI73URrvGEx9dx4E=; b=ZxaelWSEhkG7 h+3bmwTeM8h7s5b0ThK8n/4gNJgJ0yzifs0Tey4MQppalEcBLT1ey8JisE+AqjXJQcFJXQhfPsNxP sYFeUKvFVPDi2lmsGm6FsDbe8oHmVPbcSPp4CFV+IBHjfhAIV0y6CBUc8EQymSc01nUk4pEEXVvUs xXwqjV7wBLmiB1hbXjWgCk3RU4g/2uz0LU3BUE3E8DUcIdNzIj0auivyCH91+w0rB2lPzNHtfpmsg pWk6rXbLPCa0o/dOT7bZ4zQVmp9cAerwruV3yC3VUGfFL99CJzqZRwPlNVpfjCL1T7zHKmenPKWCA +7HKi/5r3SuKqNcLj7Db2Q==; Original-Received: from [87.69.77.57] (port=1391 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ83J-000611-D1; Fri, 04 Mar 2022 08:33:01 -0500 In-Reply-To: <87a6e5lui6.fsf@elite.giraud> (message from Manuel Giraud on Fri, 04 Mar 2022 14:25:37 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286820 Archived-At: > From: Manuel Giraud > Cc: Karl Fogel , emacs-devel@gnu.org > Date: Fri, 04 Mar 2022 14:25:37 +0100 > > I cannot say if it is a regression but it seems that the patch > 61e51fee9ca3 of october 17, 2020 rewrote bookmark-bmenu-mode to use > tabulated-list-mode and set the tabulated-list-sort-key on the bookmark > name. Thanks. So this did work correctly in Emacs 27.2? Or maybe you can show a simple recipe starting from "emacs -Q", then I could see for myself what happened in Emacs 27 vs Emacs 28.