From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Mon, 01 Aug 2022 18:49:30 +0300 Message-ID: <837d3s2cc5.fsf@gnu.org> References: <831qu7daxb.fsf@gnu.org> <83sfmnb7yg.fsf@gnu.org> <837d3ybh5z.fsf@gnu.org> <136c4fe0fc74196714aa@heytings.org> <83pmhp89ov.fsf@gnu.org> <136c4fe0fc39573addc9@heytings.org> <83k07x8738.fsf@gnu.org> <136c4fe0fcdf00ef9a11@heytings.org> <83h73183r7.fsf@gnu.org> <136c4fe0fc0fceb0d752@heytings.org> <838roc8ka7.fsf@gnu.org> <83tu706obt.fsf@gnu.org> <83h7306ifa.fsf@gnu.org> <83edy37pul.fsf@gnu.org> <83pmhn55sk.fsf@gnu.org> <65cb7c73fdc753518d35@heytings.org> <83fsii68o3.fsf@gnu.org> <65cb7c73fdf6704d19d5@heytings.org> <835yje62vz.fsf@gnu.org> <83r1214uz5.fsf@gnu.org> <8c7321f2f39b7a28dd18@heytings.org> <83o7x42l64.fsf@gnu.org> <83edy02j2n.fsf@gnu.org> <83a68o2i3k.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32023"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 01 17:57:56 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIXnn-00089X-2d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 17:57:55 +0200 Original-Received: from localhost ([::1]:44282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIXnl-0004kl-Pd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 11:57:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIXgA-0006yI-Rd for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 11:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIXgA-0000GQ-Hj for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 11:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIXgA-0003uL-Dr for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 11:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Aug 2022 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.165936899214997 (code B ref 56682); Mon, 01 Aug 2022 15:50:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 1 Aug 2022 15:49:52 +0000 Original-Received: from localhost ([127.0.0.1]:41444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIXg0-0003to-6t for submit@debbugs.gnu.org; Mon, 01 Aug 2022 11:49:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIXfy-0003tb-LJ for 56682@debbugs.gnu.org; Mon, 01 Aug 2022 11:49:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIXfr-00009o-Di; Mon, 01 Aug 2022 11:49:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AV781EfMuAiDtCt+5ggP7h4DRqvEKKYX9x/AyByJ09Q=; b=kfBmeQ1rzZGu e0HDcdfyhpwnbQsZDbqT4YcmdE2u7UgetPsZqDmRVSuZHOvLnF4qQxbqKISNz6dZFAYiSKWrejAgp XDBGPkdy5Kurj3pF+UrRrIEC3XJ7nKVFDzEEvGGErgDSDXwFONfecVurHadokp2uVSiUEA9cgSfzQ psoorFrt+XIHCGcbH+YEe4yh7cPj28X6f9YE/54tmBLE6P/271jUmv8MxYrB9o8NLKpyIIY125FLF TXzXOKYGueRoDdDnyzAQDOtpqt7w58HabsBI1kw4o5V5p+0q8g6BIK9jAsUP4TsOS4wat1Lu6G4my oshsq07YKM+ION7Bi8XsUA==; Original-Received: from [87.69.77.57] (port=4123 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIXfp-0006Pg-Le; Mon, 01 Aug 2022 11:49:43 -0400 In-Reply-To: (message from Gregory Heytings on Mon, 01 Aug 2022 15:08:42 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238447 Archived-At: > Date: Mon, 01 Aug 2022 15:08:42 +0000 > From: Gregory Heytings > cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, > monnier@iro.umontreal.ca > > > Or perhaps we should check that using window-point indeed brings > > pos.charpos into the narrowed region, and only use pos.charpos if it > > doesn't? > > > > I changed this into: > > if (current_buffer->long_line_optimizations_p) > { > if (!it->narrowed_begv) > { > it->narrowed_begv = get_narrowed_begv (it->w, window_point (it->w)); > it->narrowed_zv = get_narrowed_zv (it->w, window_point (it->w)); > } > else if ((pos.charpos < it->narrowed_begv || pos.charpos > it->narrowed_zv) > && (!redisplaying_p || it->line_wrap == TRUNCATE)) > { > it->narrowed_begv = get_narrowed_begv (it->w, pos.charpos); > it->narrowed_zv = get_narrowed_zv (it->w, pos.charpos); > } > } > > which seems better indeed. Is that okay from your point of view? Yes, thanks.