From: Eli Zaretskii <eliz@gnu.org>
To: Jens Lechtenboerger <lechten@wi.uni-muenster.de>,
Filipp Gunbin <fgunbin@fastmail.fm>
Cc: 58605@debbugs.gnu.org
Subject: bug#58605: 29.0.50; Commit 2a2f5530fa2 breaks ldap-search-internal
Date: Tue, 18 Oct 2022 17:17:59 +0300 [thread overview]
Message-ID: <837d0x1ai0.fsf@gnu.org> (raw)
In-Reply-To: <87wn8xr7i6.fsf@wi.uni-muenster.de> (message from Jens Lechtenboerger on Tue, 18 Oct 2022 08:05:53 +0200)
Filipp, could you please look into this issue?
> From: Jens Lechtenboerger <lechten@wi.uni-muenster.de>
> Date: Tue, 18 Oct 2022 08:05:53 +0200
>
> Hi there,
>
> commit 2a2f5530fa230e2b994be5683e63763833bb6a0a breaks
> ldap-search-internal for searches with empty results.
>
> Consider this search with ldapsearch, returning an empty result:
>
> ldapsearch -h ldap.pca.dfn.de -tt -x -b O=DFN-Verein,C=DE \
> '(mail=x@example.org)' userCertificate
> # extended LDIF
> #
> # LDAPv3
> # base <O=DFN-Verein,C=DE> with scope subtree
> # filter: (mail=x@example.org)
> # requesting: userCertificate
> #
>
> # search result
> search: 2
> result: 0 Success
>
> # numResponses: 1
>
> The problem is that ldap-search-internal interprets the 2 in line
> "search: 2" as filename with a certificate, bound to variable value.
> Thus, (insert-file-contents-literally value) results in an error:
> File is missing: "Opening input file", "Datei oder Verzeichnis nicht
> gefunden", "[currentdir]/2"
>
> Execute that:
> (let ((ldap-default-base "O=DFN-Verein,C=DE")
> (ldap-ldapsearch-args '("-x" "-tt" "-H ldaps://ldap.pca.dfn.de"))
> (search-plist '(host "" filter "mail=x@example.org" attributes ("userCertificate") attrsonly nil withdn nil)))
> (ldap-search-internal search-plist))
>
> Previously, that returned nil, after the mentioned commit it
> produces the above error.
>
> The added “?” should be removed there again:
>
> @@ -699,7 +699,7 @@ ldap-search-internal
> (forward-line 1)
> (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\
> \\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\
> -\\(<[\t ]*file://\\)\\(.*\\)$")
> +\\(<[\t ]*file://\\)?\\(.*\\)$")
> (setq name (match-string 1)
> value (match-string 4))
> ;; Need to handle file:///D:/... as generated by OpenLDAP
>
> Thanks
> Jens
>
>
>
>
next prev parent reply other threads:[~2022-10-18 14:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 6:05 bug#58605: 29.0.50; Commit 2a2f5530fa2 breaks ldap-search-internal Jens Lechtenboerger
2022-10-18 14:17 ` Eli Zaretskii [this message]
2022-10-20 8:12 ` Juri Linkov
2022-10-20 17:58 ` Filipp Gunbin
2022-10-21 6:25 ` Jens Lechtenboerger
2022-10-21 15:16 ` Filipp Gunbin
2022-10-22 9:43 ` Jens Lechtenboerger
2022-10-24 16:06 ` Filipp Gunbin
2022-10-25 5:55 ` Jens Lechtenboerger
2022-10-25 13:12 ` Filipp Gunbin
2022-10-25 13:42 ` Jens Lechtenboerger
2022-10-25 15:07 ` Filipp Gunbin
2022-10-26 6:07 ` Jens Lechtenboerger
2022-10-26 13:20 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837d0x1ai0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58605@debbugs.gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=lechten@wi.uni-muenster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.