From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 27 Oct 2022 16:15:53 +0300 Message-ID: <837d0lmmpi.fsf@gnu.org> References: <8735budxiz.fsf@gmail.com> <83a662dvgo.fsf@gnu.org> <871qqvj6qb.fsf@gmail.com> <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6991"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arstoffel@gmail.com, 58447@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 15:18:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo2lm-0001Zl-Hz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 15:18:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo2ku-0002Fl-Q9; Thu, 27 Oct 2022 09:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo2ko-00021Z-Mg for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 09:17:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo2ko-0005rg-ES for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo2ko-0002M5-5i for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.16668766059021 (code B ref 58447); Thu, 27 Oct 2022 13:17:02 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 27 Oct 2022 13:16:45 +0000 Original-Received: from localhost ([127.0.0.1]:56421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo2kL-0002LF-KG for submit@debbugs.gnu.org; Thu, 27 Oct 2022 09:16:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo2kJ-0002L1-6P for 58447@debbugs.gnu.org; Thu, 27 Oct 2022 09:16:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo2kD-0005oO-MP; Thu, 27 Oct 2022 09:16:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mSv1XlvHxEcqvOPSXOdCnLb34Uwc0SKlW6KX3nlH6kM=; b=IjskzzZI70fU klP0LaIZ0J6pu/QnJvE5qu96xsX1vJ5QTDrUWPiJ7TQg1DA9QtzB9PtsCRL7iZuu4tg4c9TATzJFY joYR1V6QpZZUX+yB6+GHV0bmZSURhNb4b/BlNr+QGXdru38QZrgljb82+X2R4/K2vgMcCv5hj/mpY mkMVRgls2sFOP6ufZslzL8jRmY6+AVz+u9Jh4+kw+7X2Eo8ZFMDskKjcBd7He0baXlJ1T7kohOyOQ BOkc0mZ50rHjKh8W5x1glBUCMI8uvFj95PBBMARYX25JSMR0JgOaTdV2Wn6BEna3jjFUz1Cx8UA4C YyQgJzsKzd0gXRdqaLICXg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo2jq-0004XE-EO; Thu, 27 Oct 2022 09:16:19 -0400 In-Reply-To: <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> (message from Dmitry Gutov on Thu, 27 Oct 2022 11:44:09 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246296 Archived-At: > Date: Thu, 27 Oct 2022 11:44:09 +0300 > Cc: 58447@debbugs.gnu.org > From: Dmitry Gutov > > On 26.10.2022 12:04, Augusto Stoffel wrote: > > I'm copying Dmitry. > > Hi! > > > On Tue, 11 Oct 2022 at 22:13, Eli Zaretskii wrote: > > > >>> From: Augusto Stoffel > >>> Date: Tue, 11 Oct 2022 20:29:24 +0200 > >>> > >>> `project-find-file' and related commands share their history with more > >>> general commands like `find-file', so they should add the absolute file > >>> name to history. Currently, file names relative to the project root are > >>> added. The attached patch fixes this. > >> Shouldn't project.el have its separate history of file names, > > I'm not sure that's useful, but then the history items should be > > absolute file names anyway. > > > >> perhaps even a project-specific history? > > This might make sense. > > I like both of these ideas, except I'm not sure how to implement the > project-specific part better. > > I suppose we won't be passing the history var to completing-read anymore? I thought about a project-specific history variable.