From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59618: 29.0.50; global-whitespace-mode + org-capture: "Marker does not point anywhere" Date: Thu, 01 Dec 2022 14:06:19 +0200 Message-ID: <837czbib0k.fsf@gnu.org> References: <86pmd969ps.fsf@aarsen.me> <83tu2lqyi6.fsf@gnu.org> <874juljl6h.fsf@localhost> <87k03gj4uw.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28613"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59618@debbugs.gnu.org, yantar92@posteo.net, arsen@aarsen.me To: Stefan Kangas , rhansen@rhansen.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 13:08:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0iMV-0007CO-Da for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 13:08:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0iMK-0002gO-JT; Thu, 01 Dec 2022 07:08:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0iME-0002dS-UJ for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 07:08:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0iME-0006vn-L2 for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 07:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0iMD-0008TO-Hk for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 07:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2022 12:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59618 X-GNU-PR-Package: emacs Original-Received: via spool by 59618-submit@debbugs.gnu.org id=B59618.166989642332561 (code B ref 59618); Thu, 01 Dec 2022 12:08:01 +0000 Original-Received: (at 59618) by debbugs.gnu.org; 1 Dec 2022 12:07:03 +0000 Original-Received: from localhost ([127.0.0.1]:39319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0iLH-0008T7-92 for submit@debbugs.gnu.org; Thu, 01 Dec 2022 07:07:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0iLC-0008Sk-C0 for 59618@debbugs.gnu.org; Thu, 01 Dec 2022 07:07:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0iL5-0006L1-5A; Thu, 01 Dec 2022 07:06:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SctHBGIZ7kY4vOolny6fKGdpU2YN+ntiBBas0+nWS1E=; b=Qt5hg1k/c1U6ZLOZFac/ 6K1LKF+DL/ZIsZ5/Ht+Hy9YlGqeyuG/k96MptrlstTu+nNBVkMfUBwa4LWpg7LTsO0EtUd36DhndX i9gX0EC1P4yiSuzscJFVH/oEDob9ev8SNUDZe0K0YyvmrdtoRK2Zv4o1r46aBB6FMc4SOHCcSJyyI ycfCw8SnTp20RBYeIejQhIcXWkcb/bKiYd7KdhekIKc+7IiiUvgLHdmJ9cNyQtkaPpmVyPw/ea43w AzKBN7Sa07gExrAUvV83rf70EqbiaoRzgzcBqy8kjAKNZrYCGHWM19Tl+FzT83c7+iCsAGZJ4AIdy XJDbNOatjamHBQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0iL2-0002vO-Tr; Thu, 01 Dec 2022 07:06:50 -0500 In-Reply-To: (message from Stefan Kangas on Sat, 26 Nov 2022 22:54:25 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249626 Archived-At: > From: Stefan Kangas > Date: Sat, 26 Nov 2022 22:54:25 -0800 > Cc: Eli Zaretskii , 59618@debbugs.gnu.org, > Arsen Arsenović , > Richard Hansen > > Stepping through `whitespace--update-bob-eob' with edebug shows that the > `goto-char' in this fragment fails, because `whitespace-bob-marker' is > nil: Is it really nil or is it a marker that "points nowhere"? This part: > Here is the backtrace again, for reference: > > Debugger entered--Lisp error: (error "Marker does not point anywhere") > whitespace--update-bob-eob(37 37 29) seems to indicate the latter. Anyway, it sounds like the changes in f47a5324f44e caused the two markers, whitespace-bob-marker and whitespace-eob-marker to sometimes "point nowhere". The band-aid patch below avoids the error reported in this bug, but redisplay still complains in *Messsages*: Error during redisplay: (jit-lock-function 45) signaled (error "Marker does not point anywhere") Richard, please chime in. Here's the band-aid patch I promised: diff --git a/lisp/whitespace.el b/lisp/whitespace.el index 25ea07e..bed2a82 100644 --- a/lisp/whitespace.el +++ b/lisp/whitespace.el @@ -2315,7 +2315,11 @@ whitespace-post-command-hook (unless (and (eq whitespace-point (point)) (not whitespace-buffer-changed)) (when (and (not whitespace-buffer-changed) - (memq 'empty whitespace-active-style)) + (memq 'empty whitespace-active-style) + (markerp whitespace-bob-marker) + (bufferp (marker-buffer whitespace-bob-marker)) + (markerp whitespace-eob-marker) + (bufferp (marker-buffer whitespace-eob-marker))) ;; No need to handle the `whitespace-buffer-changed' case here ;; because that is taken care of by the `font-lock-multiline' ;; text property. @@ -2422,6 +2426,8 @@ whitespace--update-bob-eob (widen) (let ((inhibit-read-only t)) (when (or (null beg) + (and (markerp whitespace-bob-marker) + (bufferp (marker-buffer whitespace-bob-marker)) (<= beg (save-excursion (goto-char whitespace-bob-marker) ;; Any change in the first non-`empty' @@ -2431,7 +2437,7 @@ whitespace--update-bob-eob ;; classified as `empty' (e.g., delete the ;; "x" from " x"). (forward-line 1) - (point)))) + (point))))) (goto-char 1) (set-marker whitespace-bob-marker (point)) (save-match-data @@ -2440,11 +2446,13 @@ whitespace--update-bob-eob (put-text-property (match-beginning 1) (match-end 1) 'font-lock-multiline t)))) (when (or (null end) + (and (markerp whitespace-eob-marker) + (bufferp (marker-buffer whitespace-eob-marker)) (>= end (save-excursion (goto-char whitespace-eob-marker) ;; See above comment for the BoB case. (forward-line -1) - (point)))) + (point))))) (goto-char (1+ (buffer-size))) (set-marker whitespace-eob-marker (point)) (save-match-data