From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 dc78779c0c: Fix SVG scaling (bug#59802) Date: Sat, 17 Dec 2022 12:38:08 +0200 Message-ID: <837cyqiacv.fsf@gnu.org> References: <167120580083.8436.12355011753442988358@vcs2.savannah.gnu.org> <20221216155001.8BDCAC0060F@vcs2.savannah.gnu.org> <87tu1ug6rz.fsf@yahoo.com> <83cz8iighg.fsf@gnu.org> <87len6fjdb.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40425"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, manuel@ledu-giraud.fr To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 17 11:38:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6Uae-000AKM-AJ for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Dec 2022 11:38:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6UZz-0005Ll-Lp; Sat, 17 Dec 2022 05:38:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6UZx-0005KX-G9 for emacs-devel@gnu.org; Sat, 17 Dec 2022 05:38:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6UZx-0004r9-4B; Sat, 17 Dec 2022 05:38:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sNSTf0B3fPbg9Ie6SF6cYxzp9XSWQifGjpceChuth4Q=; b=Hzdz/aLxsxrX DcohgCrmHv+1oruo5czt8U/8UD8w1QUMQO6G8kgkvAA5MbxWVm8bqtQON9P4AJs8WA6YnHU+uNYlV MSggUo69AsPPfIYigz09GS2hwUb0vTxVy1PmO1+97bZleneWg7mkYhM3sSfQJdzrS5VtIvtZF+OnD OK3PtP4+QCbiEIJX43S0iYmHtKvA6/XmvoN0c/zTMPLNTRv0/+kx5VUEhYnT6+9fEjDPS4l92csfY jFaGHEHkKd17BtW2dHUcgemg4c/nycToL8kPgUFBLKvODQJ8zVK4DBpVfljjPwi9Eycn+O1ea1jKG NZ77aw7vrYANfTPPxMYTMw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6UZw-0005VE-KG; Sat, 17 Dec 2022 05:38:04 -0500 In-Reply-To: <87len6fjdb.fsf@yahoo.com> (message from Po Lu on Sat, 17 Dec 2022 17:51:44 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301554 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org, manuel@ledu-giraud.fr > Date: Sat, 17 Dec 2022 17:51:44 +0800 > > Eli Zaretskii writes: > > >> Our style is to write: > >> > >> viewbox_width = ((viewbox_height * viewbox.width / viewbox.height) > >> * iwidth.length); > >> > >> and not: > >> > >> viewbox_width = (viewbox_height * viewbox.width / viewbox.height) > >> * iwidth.length; > > > > There's nothing wrong with the original style, although I agree that > > using extra parentheses makes it more plausible. There's no reason to > > be so stringent in insisting on the other style. > > The GNU coding standards seem to say something else: > > Insert extra parentheses so that Emacs will indent the code properly. > For example, the following indentation looks nice if you do it by > hand, Please assume I'm aware of the GCS. That section explicitly says these are recommendations, not hard requirements, a little above the text that you cite: The rest of this section gives our recommendations for other aspects of C formatting style, which is also the default style of the 'indent' program in version 1.2 and newer. It corresponds to the options -nbad -bap -nbc -bbo -bl -bli2 -bls -ncdb -nce -cp1 -cs -di2 -ndj -nfc1 -nfca -hnl -i2 -ip5 -lp -pcs -psl -nsc -nsob We don't think of these recommendations as requirements, because it causes no problems for users if two different programs have different formatting styles. So please do not push too hard for adopting only one style and nothing else. Doing so makes this community less pleasant than it should be.