From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64425: [PATCH] Mention minibuffer-next-completion in completion-help Date: Sun, 02 Jul 2023 20:16:51 +0300 Message-ID: <837crinsho.fsf@gnu.org> References: <87y1jygtra.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17865"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64425@debbugs.gnu.org To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 02 19:17:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qG0hN-0004NM-JJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jul 2023 19:17:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qG0h8-00082j-0r; Sun, 02 Jul 2023 13:17:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG0h4-00082X-Gc for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 13:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qG0h4-0005nD-7n for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 13:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qG0h4-0001Aa-3W for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 13:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2023 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64425 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64425-submit@debbugs.gnu.org id=B64425.16883181924440 (code B ref 64425); Sun, 02 Jul 2023 17:17:02 +0000 Original-Received: (at 64425) by debbugs.gnu.org; 2 Jul 2023 17:16:32 +0000 Original-Received: from localhost ([127.0.0.1]:60981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG0ga-00019Y-EF for submit@debbugs.gnu.org; Sun, 02 Jul 2023 13:16:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG0gX-00019I-WB for 64425@debbugs.gnu.org; Sun, 02 Jul 2023 13:16:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG0gS-0005kH-JV; Sun, 02 Jul 2023 13:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7Q3YRovyAmmNi1ef+b3pSunkYP8TVNOTte+Wp0giTyE=; b=Xwi+vEmZ8d0Y L3Gmg4JEdLarhBBlkM5B3SRViNLRu7+TnbYQS2AKmtdn1hcmiXXlAfB4IW6P4vRpz2HxIh6VWHHDm qvhDSIf37EERbzi9834hRi4a+DRb6EBc5nbO4ltmjrY1tPsV/E4LqO3nv5vlofm7e3s4O4WcaZU89 BUZnNRhLHkx2N+Rx/yef6i5kIQYfJgtU3Ptex/r/Bhnj7bB4x1hpts/1E4oBo+htdNYkVT83fO26f aUlWfz9d5c2Hq/KEv3fooO0G6HemMtKvTiSyxaEUejgn0Vl7txeTaiVmdw+qd//FfpSLxjrvBY0UX cNaNT3e7cdgUowNuMYWCng==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG0gK-0004xZ-7p; Sun, 02 Jul 2023 13:16:23 -0400 In-Reply-To: <87y1jygtra.fsf@catern.com> (sbaugh@catern.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264495 Archived-At: > From: sbaugh@catern.com > Date: Sun, 02 Jul 2023 16:31:21 +0000 (UTC) > > * lisp/simple.el (completion-list-mode-map): Bind > minibuffer-{next,previous,choose}-completion. > (completion-setup-function): Mention bindings for > minibuffer-{next,previous,choose}-completion. > --- > lisp/simple.el | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lisp/simple.el b/lisp/simple.el > index 406f1008df3..59e1311eb2b 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -9697,6 +9697,9 @@ completion-list-mode-map > (define-key map [right] 'next-completion) > (define-key map [?\t] 'next-completion) > (define-key map [backtab] 'previous-completion) > + (define-key map (kbd "M-") 'minibuffer-previous-completion) > + (define-key map (kbd "M-") 'minibuffer-next-completion) > + (define-key map (kbd "M-RET") 'minibuffer-choose-completion) > (define-key map "z" 'kill-current-buffer) > (define-key map "n" 'next-completion) > (define-key map "p" 'previous-completion) > @@ -10093,8 +10096,8 @@ completion-setup-function > (goto-char (point-min)) > (if (display-mouse-p) > (insert "Click on a completion to select it.\n")) > - (insert (substitute-command-keys > - "In this buffer, type \\[choose-completion] to \ > + (insert (substitute-command-keys > + "Type \\[minibuffer-next-completion] and \\[minibuffer-previous-completion] to change completion, and \\[minibuffer-choose-completion] to \ > select the completion near point.\n\n")))))) Isn't this text too long for a single screen line? If so, it will cause an annoying "jumping" of the mode line. Also, what about updating the documentation?