From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64647: Re: bug#64647: treesit-query-error due to a recent change to tree-sitter-javascript grammar definition Date: Sun, 16 Jul 2023 07:48:37 +0300 Message-ID: <837cr0bgwq.fsf@gnu.org> References: <2171209.irdbgypaU6@fedora> <874jm5rrgk.fsf@thornhill.no> <83edl9asth.fsf@gnu.org> <2891516.e9J7NaK4W3@fedora> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64647@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 06:49:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKthF-0003hN-LB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 06:49:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKtgz-0008TG-Lm; Sun, 16 Jul 2023 00:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKtgs-0008Sy-O4 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 00:49:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKtgs-0000GJ-GJ for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 00:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKtgs-0001zn-9t for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 00:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 04:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64647 X-GNU-PR-Package: emacs Original-Received: via spool by 64647-submit@debbugs.gnu.org id=B64647.16894829027568 (code B ref 64647); Sun, 16 Jul 2023 04:49:02 +0000 Original-Received: (at 64647) by debbugs.gnu.org; 16 Jul 2023 04:48:22 +0000 Original-Received: from localhost ([127.0.0.1]:46362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKtgE-0001xx-5l for submit@debbugs.gnu.org; Sun, 16 Jul 2023 00:48:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKtgB-0001xA-QG for 64647@debbugs.gnu.org; Sun, 16 Jul 2023 00:48:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKtg5-00007C-Pa; Sun, 16 Jul 2023 00:48:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=I7vhyRXeHz1iFgDda7uWgRt8MSfz1aC6RksvSz/5fDs=; b=SYj4P5X6keLo WG+SOpP1fxkwbCkgZqAvxyV5VsyUnGCnOOE2qjBZNoC6QuK9d+UrQWiPFoHQfWO/2VTEbUHa6UPip fMNWhz3gx8ahBr3qb976rhD/O3YoyBmc3TnNgjCwV+KxuFwSk7sPc5yM28eyLwwvh+nCyirzeMSdj tpTTw4sOx96S+B6YzaLd6pOALZeYxPX6gJD1lgGYA0R6JBMXE72F/hJavgRFwFlNma3W2nedVFFub oB3OuhuRccJz3H1RCd7rCqlM1Ez8LqyRJQHJ/fXPNLluaRkBbPcNzI0qIfHBAfX55of1OnHGFr97H giMLELtw+abD1hlEn0p8oQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKtg5-0000Ry-8L; Sun, 16 Jul 2023 00:48:13 -0400 In-Reply-To: <2891516.e9J7NaK4W3@fedora> (message from Vincenzo Pupillo on Sat, 15 Jul 2023 21:39:49 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265261 Archived-At: > From: Vincenzo Pupillo > Cc: jostein@kjonigsen.net, 64647@debbugs.gnu.org > Date: Sat, 15 Jul 2023 21:39:49 +0200 > > > I think what I wrote: that we should try to make our modes work with > > reasonably old versions of the grammars, if that is practical. While > > in general it could be a very difficult, if not impossible, to achieve > > that, the question is whether this particular issue can be solved in > > that manner. If it can, we should do it. > I can rewrite both patches in the same way I had patched java-ts-mode. That would be good, thanks. > Basically, there are only two changes. I think it would be useful to have a > function to check whether grammar features are supported or not. For example, > a specialized version of treesit-query-validate that could also be used in > interactive mode (to simplify the development). Yes, a good idea. > Do I rewrite the patches? Yes, please.