From: Eli Zaretskii <eliz@gnu.org>
To: monnier@iro.umontreal.ca
Cc: 65058@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de
Subject: bug#65058: 30.0.50; `find-function' can find wrong function due to implicit completion while exiting minibuffer
Date: Sat, 12 Aug 2023 09:48:33 +0300 [thread overview]
Message-ID: <837cq0g3i6.fsf@gnu.org> (raw)
In-Reply-To: <831qgiuk5g.fsf@gnu.org> (message from Eli Zaretskii on Sat, 05 Aug 2023 08:34:51 +0300)
Ping! Stefan, any comments?
> Cc: 65058@debbugs.gnu.org
> Date: Sat, 05 Aug 2023 08:34:51 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Fri, 4 Aug 2023 21:46:12 +0200
> > From: Jens Schmidt via "Bug reports for GNU Emacs,
> > the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >
> > Start from emacs -Q
> >
> > M-x find-function RET shell-mode RET
> >
> > Pops you to sh-mode. Or
> >
> > M-x find-function RET vc-create-repo RET
> >
> > Pops to vc-git-create-repo.
> >
> > Which can be confusing.
> >
> > Maybe completion in `find-function-read' should be done like this:
> >
> > diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
> > index bf890fc35a9..d393ccc759a 100644
> > --- a/lisp/emacs-lisp/find-func.el
> > +++ b/lisp/emacs-lisp/find-func.el
> > @@ -591,7 +591,7 @@ find-function-read
> > (list (intern (completing-read
> > (format-prompt "Find %s" symb prompt-type)
> > obarray predicate
> > - t nil nil (and symb (symbol-name symb)))))))
> > + 'lambda nil nil (and symb (symbol-name symb)))))))
> >
> > (defun find-function-do-it (symbol type switch-fn)
> > "Find Emacs Lisp SYMBOL in a buffer and display it.
> >
> > Ripped the symbol `lambda' from the completion of `load-file', not sure
> > whether there is any better symbol.
> >
> > Present in Emacs 29 as well.
>
> Stefan, any comments (to the problem and the proposed solution)?
>
>
>
>
next prev parent reply other threads:[~2023-08-12 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 19:46 bug#65058: 30.0.50; `find-function' can find wrong function due to implicit completion while exiting minibuffer Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 5:34 ` Eli Zaretskii
2023-08-12 6:48 ` Eli Zaretskii [this message]
2023-08-12 18:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-13 6:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837cq0g3i6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65058@debbugs.gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.