From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Date: Mon, 04 Sep 2023 15:44:34 +0300 Message-ID: <837cp65cr1.fsf@gnu.org> References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36362"; mail-complaints-to="usenet@ciao.gmane.io" Cc: felician.nemeth@gmail.com, philipk@posteo.net, filippo.argiolas@gmail.com, 65418@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 14:46:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qd8y8-0009CQ-8V for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 14:46:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qd8xy-0006wT-Jk; Mon, 04 Sep 2023 08:46:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd8xv-0006d4-Cc for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 08:46:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qd8xv-0005Uh-25 for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 08:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qd8xu-0003S6-AR for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 08:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169383150513198 (code B ref 65418); Mon, 04 Sep 2023 12:46:02 +0000 Original-Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 12:45:05 +0000 Original-Received: from localhost ([127.0.0.1]:49033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8wz-0003Qo-AC for submit@debbugs.gnu.org; Mon, 04 Sep 2023 08:45:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8wt-0003Pt-MV for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 08:45:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd8wn-0004yQ-HR; Mon, 04 Sep 2023 08:44:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=erRtVjC6kQNNDLd5NYUGVc57DiKYHrQTO1KEr/tAqWM=; b=PosLZe2otLebhG5CK8ex jiWpAg/VZypk1/lhb5I83YweoJI89wlq6CWqe0KbAr2vLBSfaZlkfCgjNEDag6rRus/dEFEXAMpKu LiaMEu7mpPAQvlgum+6vKWg9PvKLs/bn1dr4xGpXj8tbIaXMaGy4rslJyfaAlovYnAJRvkDX3gndg h+95k6Lp+a2GdUOQJXQd6/b5uIjLRzkEEHtMhVvvK1BCmb8fwlcbwmnzWY8RhIyHq5ZLNZmvlqKic Xx5acu3WIz/fgh+/dWdxqsHA6m/mpZ4BxX76rUrzPmKAw/jb6EXJQu1sRS/dNtq41KbF99p+RPrYj oLlVF80i8Vco4A==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Mon, 4 Sep 2023 11:51:33 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269236 Archived-At: > From: João Távora > Date: Mon, 4 Sep 2023 11:51:33 +0100 > Cc: Eli Zaretskii , Felician Nemeth , 65418@debbugs.gnu.org, > Philip Kaludercic > > On Mon, Sep 4, 2023 at 5:09 AM Filippo Argiolas > wrote: > > > > On Mon, Sep 4, 2023 at 5:59 AM Filippo Argiolas > > wrote: > > > > > > On Mon, Sep 4, 2023 at 3:06 AM João Távora wrote: > > > > > > > > On Mon, Sep 4, 2023 at 2:05 AM João Távora wrote: > > > > > > > > > > On Thu, Aug 31, 2023 at 6:28 PM Filippo Argiolas > > > > > wrote: > > > > > > > > > > > > On Sun, Aug 27, 2023 at 3:58 PM João Távora wrote: > > > > > > > Glad to help. You're lucky I'm not some kind of wine connoisseur ;-) > > > > > > > Make a patch for that (and remember to also include the exportation of > > > > > > > the '--' symbols). > > > > > > > > > > > > > > > > > > > Many thanks again! That code definitely made this work week more enjoyable ;-) > > > > > > > > > > > > Sorry for the delay with the patch, little time left these days for > > > > > > side projects or even trivial contributions like this. > > > > > > See if the attached patches could do! > > > > > > > > > > They were very helpful. I just pushed heavily edited versions of > > > > > them to master. I used them as a starting point and credited you as > > > > > co-author (I could have done the other way round, crediting myself > > > > > as co-author, but the changes I did were a bit too extensive for > > > > > that). > > > > > > No problem for me, edit as much as you want! just glad to help. > > > I'd be just as happy if you just thanked me in the commit message. > > > > By the way I looked at your doc version and very much approve it. The > > one about public API I think I don't even deserve co-authorship :-D > > It's mainly because i started by applying your patch then doing multiple > changes to them. > > My intuition also tells me that the remnants of both your > contribution are indeed "trivial" (as measured both in absolute LOC > and complexity) > > But I admit I'm not fully aware of how these things are counted > "officially", so better safe than sorry and I reverted them. But > I would very much like to re-revert of course, as this was a lot > of work and is a pretty valuable change, IMO. Let's wait for Eli to > explain how to proceed. To provide a helpful answer I need to know how much code was provided by Filippo. Where can I see that?