From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Nikishkin <for_emacs-recentf-patch_2023-12-21@lockywolf.net>
Cc: 67946@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#67946: 30.0.50; [RFC PATCH] Add an option to not report "Wrote ..." when saving recentf.
Date: Tue, 26 Dec 2023 14:41:56 +0200 [thread overview]
Message-ID: <837cl19luz.fsf@gnu.org> (raw)
In-Reply-To: <87plyt4i6k.fsf@laptop.lockywolf.net> (message from Vladimir Nikishkin on Tue, 26 Dec 2023 13:58:45 +0800)
> From: Vladimir Nikishkin <for_emacs-recentf-patch_2023-12-21@lockywolf.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, 67946@debbugs.gnu.org
> Date: Tue, 26 Dec 2023 13:58:45 +0800
>
> Stefan Kangas <stefankangas@gmail.com> writes:
>
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >> If we decide to turn it off, we will need a knob to revert to the old
> >> behavior, because after so many years of the existing behavior,
> >> someone somewhere might be used to it.
> >
> > I think the existing patch basically has that already, but it seems to
> > be lacking a NEWS entry and a :version tag for the defcustom before it
> > can go in.
> >
> > Vladimir, could you fix that and send a new patch?
>
> Added an entry to etc/NEWS, and, seems, fixed the actual verbosity
> message printing condition.
Thanks, a few minor comments:
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1046,7 +1046,11 @@ desktop restoration to continue.
> Similarly to buffer restoration by Desktop, 'recentf-mode' checking
> of the accessibility of remote files can now time out if
> 'remote-file-name-access-timeout' is set to a positive number.
> -
That empty separator line should not be deleted.
> +*** New use option 'recentf-verbose'.
^^^
"user"
> +By default 'recentf-save-list' prints a message when saving the
> +recentf list. The new option, if set to nil, suppresses this message.
^^
Two spaces between sentences, please.
> +If more debugging info suppression switches are to be added, this
> +option might become more useful.
I don't think we need this last sentence in NEWS. NEWS is about
changes that are actually done, not about potential changes in the
future.
> +(defcustom recentf-verbose 1
> + "0 means to not show debugging messages related to the recentf machinery.
> +1 means show messages that were printed by default on Emacs <= 29.1."
A doc string should start with a single sentence that summarizes what
the variable or function does. In this case, I suggest
Whether to show verbose messages about low-level recentf actions.
Also, if we are going to use an integer here, the variable should be
called something like recentf-verbosity. Alternatively, we could make
it a simple boolean, since we have no plans to extend it to more than
2 levels.
> + :group 'recentf
Do you need this :group tag? It shouldn't be needed in this case, I
think.
Finally, the commit log message is still missing.
prev parent reply other threads:[~2023-12-26 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 3:26 bug#67946: 30.0.50; [RFC PATCH] Add an option to not report "Wrote ..." when saving recentf Vladimir Nikishkin
2023-12-21 9:37 ` Eli Zaretskii
2023-12-24 14:39 ` Stefan Kangas
2023-12-25 5:17 ` Vladimir Nikishkin
2023-12-25 12:25 ` Eli Zaretskii
2023-12-25 21:50 ` Stefan Kangas
2023-12-26 5:58 ` Vladimir Nikishkin
2023-12-26 12:41 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837cl19luz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67946@debbugs.gnu.org \
--cc=for_emacs-recentf-patch_2023-12-21@lockywolf.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.