From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Sun, 07 Jan 2024 09:09:40 +0200 Message-ID: <837cklsjpn.fsf@gnu.org> References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> <87le9297ei.fsf@yahoo.com> <87cyue92fx.fsf@yahoo.com> <877ckm8uzz.fsf@yahoo.com> <83v886sgtl.fsf@gnu.org> <83plyescg9.fsf@gnu.org> <87wmsl7wh9.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24747"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 07 08:10:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMNIY-00069i-Id for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Jan 2024 08:10:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMNI8-0007kL-C1; Sun, 07 Jan 2024 02:09:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMNI4-0007kC-Ti for emacs-devel@gnu.org; Sun, 07 Jan 2024 02:09:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMNI4-0003LM-KV; Sun, 07 Jan 2024 02:09:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yofInDbkmB8PWgguDb5HGQGeGonlvvB93qdVG5pqX00=; b=l8iHj3vzRsl/ aWnc1NJ2YPnWR7ef40Pn0/T5ntssTmuqlBUZoPym0Pk9jHoMaDBEZL33WXuBMgX1hTw2AFeZaTqiY vlgXymTHSC1OJVJRNFlas2sC/rSVtcsBgUsOd9ZKnibNzZw696o7Kj7JR3AIYjrJKo6GfrX5SOblk 5XWmi19iM21MyxebTC/yI0BBKpOdWCzZdaglgQ0CNxl2yYKmJFnbHjpM3PTuhEImCGSGDy+NsbJzV JDQw3maOUaNY2BQHQ4yNSbx96NUGf9m2/nv5dv8GfFNQzlGoWHTeNkrRriIOCUdUDHaGa7rhQ8Bsp /oh5CYuo7xPnNP77kCgThg==; In-Reply-To: <87wmsl7wh9.fsf@yahoo.com> (message from Po Lu on Sun, 07 Jan 2024 09:39:30 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314670 Archived-At: > From: Po Lu > Cc: stefankangas@gmail.com, emacs-devel@gnu.org > Date: Sun, 07 Jan 2024 09:39:30 +0800 > > Eli Zaretskii writes: > > > Then you could have easily fixed the change instead of reverting it, > > right? Why didn't you? > > Because the change cannot be fixed in such a way that all affected > systems will correctly build Emacs, and is impossible to implement in C. Sorry, I don't understand. AFAICT, something like #if SUN # define TYPEOF __typeof__ #else # define TYPEOF __typeof #endif would have solved the problem of the compiler with which you had the problem. If not, why not? If the above would solve the problem, why didn't you fix the commit that way, instead of reverting?