From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive Date: Wed, 18 Mar 2020 16:31:49 +0100 Message-ID: <837B3AF9-46ED-415A-BDFE-251BD97ECBB8@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_DCA11AB2-E784-4982-BD91-7AEF01E145F1" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99208"; mail-complaints-to="usenet@ciao.gmane.io" To: 40119@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 18 16:32:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEagA-000PgY-Jt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Mar 2020 16:32:22 +0100 Original-Received: from localhost ([::1]:52364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEag9-0005Qz-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Mar 2020 11:32:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33763) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEafx-0005Qf-Vr for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 11:32:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEafu-0005Pa-CE for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 11:32:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEafq-0005KQ-4N for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 11:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jEafq-0004yO-1c for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 11:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Mar 2020 15:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40119 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158454552019105 (code B ref -1); Wed, 18 Mar 2020 15:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Mar 2020 15:32:00 +0000 Original-Received: from localhost ([127.0.0.1]:41056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEafn-0004y5-N6 for submit@debbugs.gnu.org; Wed, 18 Mar 2020 11:31:59 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEafm-0004xy-Mc for submit@debbugs.gnu.org; Wed, 18 Mar 2020 11:31:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33712) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEafk-0005QB-RV for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 11:31:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEafj-0005Ad-GY for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 11:31:56 -0400 Original-Received: from mail1441c50.megamailservers.eu ([91.136.14.41]:54882 helo=mail264c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEafi-00052U-Rc for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 11:31:55 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1584545512; bh=Hx0RmB1F3a230yeNzEnfPLKsGohrV0i/gd2bPKTk31Q=; h=From:Subject:Date:To:From; b=UwCvCuvgWSPf4GLeLbdCj7LOxlweFrJ0bEuaWbCYH3QN41wCOYB5b9YcDzv8LrQWO jD0tedpUBAsc8lC1NvLWWo8ElW0Xd8DO54Tlt8RN+SqCdXYt1L4WFTwpLjTjC50qDI R8ptLeKrWxDAlkntKXDCg3ZA90htjOTZd3mSrJ/Q= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 02IFVnY7008559 for ; Wed, 18 Mar 2020 15:31:51 +0000 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A782F1D.5E723ED3.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=PPNxBsiC c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=M51BFTxLslgA:10 a=xQ1sb2qxdp5jxXDeoLIA:9 a=CjuIK1q_8ugA:10 a=Bh4lUqT-VzVNrQDYI54A:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177503 Archived-At: --Apple-Mail=_DCA11AB2-E784-4982-BD91-7AEF01E145F1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Since the regexps being matched in compilation-mode are numerous, = independently written, and often intersect, it makes sense to use = case-sensitive matching. After all, compiler messages do not change case = between runs. Doing so improves performance: case-insensitive matching is slightly = slower and stricter matching allows for earlier rejection. It also = reduces collisions, and it is probably what everybody assumed anyway. --Apple-Mail=_DCA11AB2-E784-4982-BD91-7AEF01E145F1 Content-Disposition: attachment; filename=0001-Make-compilation-mode-regexp-matching-case-sensitive.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Make-compilation-mode-regexp-matching-case-sensitive.patch" Content-Transfer-Encoding: quoted-printable =46rom=20c48d1607d2401f1bd6e05a3f44c7f9ec8ec30b91=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=2018=20Mar=202020=2016:01:02=20+0100=0A= Subject:=20[PATCH]=20Make=20compilation-mode=20regexp=20matching=20= case-sensitive=0A=0AThe=20number=20of=20regexps=20is=20large,=20they=20= are=20often=20written=20independently=0Aof=20one=20another,=20and=20they=20= frequently=20intersect.=20=20Enforcing=0Acase-sensitive=20matching=20= improves=20separation=20and=20performance,=20and=0Ais=20probably=20what=20= everyone=20have=20being=20assuming=20all=20along.=0A=0A*=20= lisp/progmodes/compile.el=20(compilation-parse-errors):=0ABind=20= case-fold-search=20to=20nil=20during=20matching.=0A*=20etc/NEWS:=20= Announce.=0A---=0A=20etc/NEWS=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20|=204=20++++=0A=20lisp/progmodes/compile.el=20|=203=20++-=0A=20= 2=20files=20changed,=206=20insertions(+),=201=20deletion(-)=0A=0Adiff=20= --git=20a/etc/NEWS=20b/etc/NEWS=0Aindex=2087e634f2c1..8bea9b2d5f=20= 100644=0A---=20a/etc/NEWS=0A+++=20b/etc/NEWS=0A@@=20-174,6=20+174,10=20= @@=20key=20=20=20=20=20=20=20=20=20=20=20=20=20binding=0A=20/=20v=20=20=20= =20=20=20=20=20=20=20=20=20=20package-menu-filter-by-version=0A=20/=20/=20= =20=20=20=20=20=20=20=20=20=20=20=20package-menu-filter-clear=0A=20=0A= +**=20Compilation=20mode=0A+=0A+***=20Regexp=20matching=20of=20messages=20= is=20now=20case-sensitive.=0A+=0A=20=0C=0A=20*=20New=20Modes=20and=20= Packages=20in=20Emacs=2028.1=0A=20=0Adiff=20--git=20= a/lisp/progmodes/compile.el=20b/lisp/progmodes/compile.el=0Aindex=20= 455f181f50..aefaa1707a=20100644=0A---=20a/lisp/progmodes/compile.el=0A= +++=20b/lisp/progmodes/compile.el=0A@@=20-1435,7=20+1435,8=20@@=20= compilation-parse-errors=0A=20=20=20=20=20(if=20(symbolp=20item)=0A=20=20= =20=20=20=20=20=20=20(setq=20item=20(cdr=20(assq=20item=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20compilation-error-regexp-alist-alist))))=0A-=20=20=20=20(let=20((file=20= (nth=201=20item))=0A+=20=20=20=20(let=20((case-fold-search=20nil)=0A+=20=20= =20=20=20=20=20=20=20=20(file=20(nth=201=20item))=0A=20=20=20=20=20=20=20= =20=20=20=20(line=20(nth=202=20item))=0A=20=20=20=20=20=20=20=20=20=20=20= (col=20(nth=203=20item))=0A=20=20=20=20=20=20=20=20=20=20=20(type=20(nth=20= 4=20item))=0A--=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_DCA11AB2-E784-4982-BD91-7AEF01E145F1--