From: "Mattias Engdegård" <mattiase@acm.org>
To: 40119@debbugs.gnu.org
Subject: bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive
Date: Wed, 18 Mar 2020 16:31:49 +0100 [thread overview]
Message-ID: <837B3AF9-46ED-415A-BDFE-251BD97ECBB8@acm.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
Since the regexps being matched in compilation-mode are numerous, independently written, and often intersect, it makes sense to use case-sensitive matching. After all, compiler messages do not change case between runs.
Doing so improves performance: case-insensitive matching is slightly slower and stricter matching allows for earlier rejection. It also reduces collisions, and it is probably what everybody assumed anyway.
[-- Attachment #2: 0001-Make-compilation-mode-regexp-matching-case-sensitive.patch --]
[-- Type: application/octet-stream, Size: 1718 bytes --]
From c48d1607d2401f1bd6e05a3f44c7f9ec8ec30b91 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
Date: Wed, 18 Mar 2020 16:01:02 +0100
Subject: [PATCH] Make compilation-mode regexp matching case-sensitive
The number of regexps is large, they are often written independently
of one another, and they frequently intersect. Enforcing
case-sensitive matching improves separation and performance, and
is probably what everyone have being assuming all along.
* lisp/progmodes/compile.el (compilation-parse-errors):
Bind case-fold-search to nil during matching.
* etc/NEWS: Announce.
---
etc/NEWS | 4 ++++
lisp/progmodes/compile.el | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/etc/NEWS b/etc/NEWS
index 87e634f2c1..8bea9b2d5f 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -174,6 +174,10 @@ key binding
/ v package-menu-filter-by-version
/ / package-menu-filter-clear
+** Compilation mode
+
+*** Regexp matching of messages is now case-sensitive.
+
\f
* New Modes and Packages in Emacs 28.1
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 455f181f50..aefaa1707a 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1435,7 +1435,8 @@ compilation-parse-errors
(if (symbolp item)
(setq item (cdr (assq item
compilation-error-regexp-alist-alist))))
- (let ((file (nth 1 item))
+ (let ((case-fold-search nil)
+ (file (nth 1 item))
(line (nth 2 item))
(col (nth 3 item))
(type (nth 4 item))
--
2.21.1 (Apple Git-122.3)
next reply other threads:[~2020-03-18 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 15:31 Mattias Engdegård [this message]
2020-03-18 18:05 ` bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive Eli Zaretskii
2020-03-18 18:30 ` Mattias Engdegård
2020-03-18 19:29 ` Eli Zaretskii
2020-03-18 22:05 ` Mattias Engdegård
2020-03-25 20:41 ` Mattias Engdegård
2020-03-25 20:55 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837B3AF9-46ED-415A-BDFE-251BD97ECBB8@acm.org \
--to=mattiase@acm.org \
--cc=40119@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.