From: Seiji Zenitani <zenitani@mac.com>
To: emacs-devel@gnu.org
Subject: [OS X] Title bar icon
Date: Sun, 26 Aug 2007 11:55:11 -0400 [thread overview]
Message-ID: <8370BFE3-71F2-4848-9E05-A16C06CD1C2D@mac.com> (raw)
Hi,
When visiting a file, the Carbon (OS X) port displays a small proxy
icon in the window title bar, like other OS X applications.
However, the proxy icon disappears when the cursor temporary visits
the mini buffer (i.e. saving the buffer to another file by C-x C-w),
often enough to attract the user's attention. I don't think it is
necessary to update the proxy icon in the case of the mini buffer,
because the mini buffer usually receives the user's input or shows a
message. How about disabling the update_proxy_icon function in the
mini buffer? I use the following patch in order to modify the above
behavior.
Seiji Zenitani
zenitani@mac.com
--- src/macfns.c.orig 2007-07-25 23:05:09.000000000 -0400
+++ src/macfns.c 2007-07-28 22:34:13.000000000 -0400
@@ -2111,16 +2138,15 @@
return;
w = XWINDOW (FRAME_SELECTED_WINDOW (f));
+ if (MINI_WINDOW_P (w))
+ return;
+
modified_p = (BUF_SAVE_MODIFF (XBUFFER (w->buffer))
< BUF_MODIFF (XBUFFER (w->buffer)));
if (windows_or_buffers_changed
- /* Minibuffer modification status shown in the close button is
- confusing. */
- || (!MINI_WINDOW_P (w)
- && (modified_p != !NILP (w->last_had_star))))
+ || (modified_p != !NILP (w->last_had_star)))
{
- SetWindowModified (FRAME_MAC_WINDOW (f),
- !MINI_WINDOW_P (w) && modified_p);
+ SetWindowModified (FRAME_MAC_WINDOW (f), modified_p);
mac_update_proxy_icon (f);
}
#endif
next reply other threads:[~2007-08-26 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-26 15:55 Seiji Zenitani [this message]
2007-08-27 0:22 ` [OS X] Title bar icon YAMAMOTO Mitsuharu
2007-08-27 1:45 ` Seiji Zenitani
2007-08-27 7:47 ` David Reitter
2007-08-27 8:57 ` YAMAMOTO Mitsuharu
2007-08-27 18:37 ` David Reitter
2007-08-27 3:07 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8370BFE3-71F2-4848-9E05-A16C06CD1C2D@mac.com \
--to=zenitani@mac.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.