From: Eli Zaretskii <eliz@gnu.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: emacs-devel@gnu.org, drew.adams@oracle.com, mathias.dahl@gmail.com
Subject: Re: Willing to debug bug #3542 (23.0.94; File access via UNC path slow again under Windows)
Date: Thu, 09 Jul 2009 21:47:31 +0300 [thread overview]
Message-ID: <8363e1zoak.fsf@gnu.org> (raw)
In-Reply-To: <4A5619F5.8010008@gnu.org>
> Date: Fri, 10 Jul 2009 00:25:25 +0800
> From: Jason Rumney <jasonr@gnu.org>
> CC: 'Mathias Dahl' <mathias.dahl@gmail.com>,
> 'Eli Zaretskii' <eliz@gnu.org>,
> emacs-devel@gnu.org
>
> Drew Adams wrote:
> >> Hmm... There is a suggestion to use it only on fast machines at the
> >> same time it is turned on by default. Shouldn't it be the other way
> >> around? Btw, I consider my machine to be quite fast even though it is
> >> a couple of years old.
> >>
> >> I suggest we change the default value of this variable to nil (or make
> >> the code faster).
> >>
> >
> > Dumb question: Is there a way for Emacs to know whether the format is NTFS or
> > FAT(32)? If so, then Emacs could use nil for FAT volumes.
> >
> That suggestion dates back to the days when "fast machines" were running
> at 200MHz or so. The problem here is not the speed of the machine, but
> the network. The default value of w32-get-true-file-attributes is
> 'local, which means nil when going across the network, but apparently
> that is not being recognized in all places - which I think is what Eli
> is investigating.
Right. We didn't treat UNC file names as remote, it's as simple as
that.
I installed the patch below on the trunk.
Stefan and Yidong, is it okay to install on the release branch as
well?
2009-07-09 Eli Zaretskii <eliz@gnu.org>
* w32.c (stat): Treat UNC file names as residing on remote
drives. (Bug#3542)
--- src/w32.c.orig 2009-06-21 10:38:18.000000000 +0300
+++ src/w32.c 2009-07-09 16:31:51.250000000 +0300
@@ -3154,11 +3154,13 @@
}
}
- /* GetDriveType needs the root directory of NAME's drive. */
- if (!(strlen (name) >= 2 && IS_DEVICE_SEP (name[1])))
- devtype = GetDriveType (NULL); /* use root of current diectory */
+ if (IS_DIRECTORY_SEP (name[0]) && IS_DIRECTORY_SEP (name[1]))
+ devtype = DRIVE_REMOTE; /* assume UNC name is remote */
+ else if (!(strlen (name) >= 2 && IS_DEVICE_SEP (name[1])))
+ devtype = GetDriveType (NULL); /* use root of current drive */
else
{
+ /* GetDriveType needs the root directory of NAME's drive. */
strncpy (drive_root, name, 3);
drive_root[3] = '\0';
devtype = GetDriveType (drive_root);
next prev parent reply other threads:[~2009-07-09 18:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 21:01 Willing to debug bug #3542 (23.0.94; File access via UNC path slow again under Windows) Mathias Dahl
2009-07-05 22:58 ` Chong Yidong
2009-07-06 14:30 ` Mathias Dahl
2009-07-06 14:55 ` Chong Yidong
2009-07-07 11:00 ` Mathias Dahl
2009-07-07 11:14 ` Miles Bader
2009-07-06 3:06 ` Eli Zaretskii
2009-07-06 7:38 ` Mathias Dahl
2009-07-06 20:01 ` Eli Zaretskii
2009-07-08 15:01 ` Eli Zaretskii
2009-07-08 20:47 ` Mathias Dahl
2009-07-09 11:37 ` Jason Rumney
2009-07-09 11:53 ` Mathias Dahl
2009-07-09 16:11 ` Drew Adams
2009-07-09 16:25 ` Jason Rumney
2009-07-09 17:03 ` Drew Adams
2009-07-09 18:59 ` Eli Zaretskii
2009-07-09 18:47 ` Eli Zaretskii [this message]
2009-07-09 21:33 ` Chong Yidong
2009-07-10 8:54 ` Eli Zaretskii
2009-07-11 19:17 ` Stefan Monnier
2009-07-11 20:22 ` Eli Zaretskii
2009-07-13 12:17 ` Stefan Monnier
2009-07-13 13:38 ` Andreas Schwab
2009-07-13 19:00 ` Eli Zaretskii
2009-07-13 18:56 ` Eli Zaretskii
2009-07-14 0:51 ` Stefan Monnier
2009-07-13 13:57 ` Andreas Schwab
2009-07-13 19:02 ` Eli Zaretskii
2009-07-13 19:39 ` Andreas Schwab
2009-07-13 20:13 ` Eli Zaretskii
2009-07-13 21:04 ` Andreas Schwab
2009-07-13 23:29 ` Chong Yidong
2009-07-14 0:31 ` YAMAMOTO Mitsuharu
2009-07-14 0:54 ` Stefan Monnier
2009-07-14 3:18 ` Eli Zaretskii
2009-07-14 4:28 ` Miles Bader
2009-07-14 19:14 ` Eli Zaretskii
2009-07-14 19:32 ` Davis Herring
2009-07-14 20:03 ` Eli Zaretskii
2009-07-14 20:27 ` Miles Bader
2009-07-14 21:05 ` Eli Zaretskii
2009-07-15 9:19 ` David Kastrup
2009-07-14 4:31 ` Haojun Bao
2009-07-14 18:18 ` Stefan Monnier
2009-07-14 19:57 ` Eli Zaretskii
2009-07-09 19:11 ` Eli Zaretskii
2009-07-09 19:13 ` Eli Zaretskii
2009-07-09 12:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8363e1zoak.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
--cc=mathias.dahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.