From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Subject: Redundant if clause in xdisp.c?
Date: Sat, 29 Aug 2009 15:46:32 +0300 [thread overview]
Message-ID: <8363c6bxef.fsf@gnu.org> (raw)
Unless I'm missing something, both branches of the if clause below
(from xdisp.c:redisplay_internal) are identical, except for the
comments:
if (Z - CHARPOS (tlendpos) == ZV)
{
/* This line ends at end of (accessible part of)
buffer. There is no newline to count. */
delta = (Z
- CHARPOS (tlendpos)
- MATRIX_ROW_START_CHARPOS (row));
delta_bytes = (Z_BYTE
- BYTEPOS (tlendpos)
- MATRIX_ROW_START_BYTEPOS (row));
}
else
{
/* This line ends in a newline. Must take
account of the newline and the rest of the
text that follows. */
delta = (Z
- CHARPOS (tlendpos)
- MATRIX_ROW_START_CHARPOS (row));
delta_bytes = (Z_BYTE
- BYTEPOS (tlendpos)
- MATRIX_ROW_START_BYTEPOS (row));
}
increment_matrix_positions (w->current_matrix,
this_line_vpos + 1,
w->current_matrix->nrows,
delta, delta_bytes);
Okay to remove the condition and to collapse both branches into a
single code fragment?
next reply other threads:[~2009-08-29 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 12:46 Eli Zaretskii [this message]
2009-08-29 14:16 ` Redundant if clause in xdisp.c? Chong Yidong
2009-08-29 15:50 ` Stefan Monnier
2009-08-29 17:40 ` Eli Zaretskii
2009-08-29 21:21 ` Stefan Monnier
2009-08-30 18:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8363c6bxef.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.