From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Cygwin patches Date: Sat, 21 Nov 2009 14:42:02 +0200 Message-ID: <836394oxr9.fsf@gnu.org> References: <4B06F562.8060504@cornell.edu> <871vjs7tn4.fsf@stupidchicken.com> <4B071784.5030901@cornell.edu> <83my2gpa83.fsf@gnu.org> <4B07D914.8070608@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1258807789 27851 80.91.229.12 (21 Nov 2009 12:49:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Nov 2009 12:49:49 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 21 13:49:42 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NBpPH-0001ji-9B for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2009 13:49:41 +0100 Original-Received: from localhost ([127.0.0.1]:51610 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBpPG-0001fy-Iv for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2009 07:49:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBpMa-0000rB-0V for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:46:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBpMV-0000ow-0H for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:46:51 -0500 Original-Received: from [199.232.76.173] (port=60138 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBpMU-0000oo-Pa for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:46:46 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:25231) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBpMU-00077B-FH for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:46:46 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBpMT-00077n-JE for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:46:45 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KTG00K00LSPPG00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sat, 21 Nov 2009 14:42:02 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.37.193]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KTG00G2XLY1K6B0@a-mtaout22.012.net.il>; Sat, 21 Nov 2009 14:42:02 +0200 (IST) In-reply-to: <4B07D914.8070608@cornell.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117442 Archived-At: > Date: Sat, 21 Nov 2009 07:12:04 -0500 > From: Ken Brown > CC: cyd@stupidchicken.com, emacs-devel@gnu.org > > > I think that the right fix would be in browse-url-file-url, so that it > > does return a correctly converted URL. Using cygstart directly in > > browse-url-of-file deviates too much from what other platforms do -- > > they all invoke the browser in browse-url. Such a deviation could > > mean maintenance headaches in the future. For example, browse-url > > takes care of setting the environment for the process being invoked, > > while your patch short-circuits that for Cygwin. > > OK, that makes sense. I'll figure out how to patch browse-url-file-url > instead. Thanks. > But it will still mean cygwin-specific code in that function. > Is that acceptable? Yes, of course. > [BTW, Lennart's suggestion that the cygwin-specific code should be moved > to browse-url doesn't work. In fact, browse-url works fine on cygwin as > is; it just needs to be given a good URL.] Right, I figured that much.