From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: size_t vs EMACS_INT
Date: Fri, 15 Jul 2011 09:42:41 +0300 [thread overview]
Message-ID: <8362n4hwny.fsf@gnu.org> (raw)
Paul,
I think that part of your change in revision 105217 on the trunk, viz.
-static size_t bidi_cache_size = 0;
+static EMACS_INT bidi_cache_size = 0;
is not a good idea. I understand the motivation for using a signed
type, but EMACS_INT isn't just a signed type, it's 3 bits narrower
than size_t, at least on some platforms. By contrast, the bidi cache
should be able to support the longest Lisp string/buffer, and for that
it needs to have MOST_POSITIVE_FIXNUM _elements_, not bytes. So the
net effect of the above change is to limit the cache to 1/8th of the
maximum size it could have before the change. So I think we will have
to use size_t here, and deal with whatever complications that causes
with GCC 4.6.x.
next reply other threads:[~2011-07-15 6:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 6:42 Eli Zaretskii [this message]
2011-07-15 7:15 ` size_t vs EMACS_INT Paul Eggert
2011-07-15 8:10 ` Eli Zaretskii
2011-07-15 16:38 ` Paul Eggert
2011-07-15 17:14 ` Eli Zaretskii
2011-07-15 21:52 ` Paul Eggert
2011-07-16 7:13 ` Eli Zaretskii
2011-07-16 11:02 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8362n4hwny.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.