From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109223: Utility function to make a list from specified amount of objects. Date: Fri, 27 Jul 2012 13:37:25 +0300 Message-ID: <836299jxqy.fsf@gnu.org> References: "E1SudrQ-0006f7-Rk@vcs.savannah.gnu.org" <50123904.9040005@gmx.at> <501249A3.1090103@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1343385466 26192 80.91.229.3 (27 Jul 2012 10:37:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2012 10:37:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 27 12:37:45 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SuhvV-0006G6-3E for ged-emacs-devel@m.gmane.org; Fri, 27 Jul 2012 12:37:45 +0200 Original-Received: from localhost ([::1]:41631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuhvU-0003eT-25 for ged-emacs-devel@m.gmane.org; Fri, 27 Jul 2012 06:37:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuhvM-0003eA-AM for emacs-devel@gnu.org; Fri, 27 Jul 2012 06:37:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuhvL-0000ve-7j for emacs-devel@gnu.org; Fri, 27 Jul 2012 06:37:36 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:54142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuhvK-0000uj-VK for emacs-devel@gnu.org; Fri, 27 Jul 2012 06:37:35 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M7T00B00DQLQQ00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Fri, 27 Jul 2012 13:37:19 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M7T00B21EU6PO70@a-mtaout22.012.net.il>; Fri, 27 Jul 2012 13:37:19 +0300 (IDT) In-reply-to: <501249A3.1090103@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151913 Archived-At: > Date: Fri, 27 Jul 2012 11:56:19 +0400 > From: Dmitry Antipov > Cc: emacs-diffs@gnu.org, Emacs development discussions > > On 07/27/2012 10:45 AM, martin rudalics wrote: > > > revno: 109223 > > committer: Dmitry Antipov > > branch nick: trunk > > timestamp: Fri 2012-07-27 10:04:35 +0400 > > message: > > Utility function to make a list from specified amount of objects. > > * lisp.h (enum constype): New datatype. > > (listn): New prototype. > > * alloc.c (listn): New function. > > (Fmemory_use_count, syms_of_alloc): Use it. > > * buffer.c (syms_of_buffer): Likewise. > > * callint.c (syms_of_callint): Likewise. > > * charset.c (define_charset_internal): Likewise. > > * coding.c (syms_of_coding): Likewise. > > * keymap.c (syms_of_keymap): Likewise. > > * search.c (syms_of_search): Likewise. > > * syntax.c (syms_of_syntax): Likewise. > > * w32.c (init_environment): Likewise. > > * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise. > > * xdisp.c (syms_of_xdisp): Likewise. > > * xfns.c (syms_of_xfns): Likewise. > > > > gets me > > > > w32.c: In function 'init_environment': > > w32.c:1727:34: error: expected ')' before ';' token > > make[1]: *** [oo/i386/w32.o] Error 1 > > make[1]: Leaving directory `c:/emacs/trunk/src' > > make: *** [all-other-dirs-gmake] Error 2 In addition, there was a more serious error in listn: it consed the arguments in the wrong order: from first to last, instead of the other way around. This caused incorrect frame title to be displayed, but also had other manifestations: e.g., memory-use-counts would display its results in the reversed order. (I fixed listn in revision 109230.) Dmitry, I wonder how you tested listn, that left these problems undetected. Just stepping into memory-use-counts with a debugger and comparing the values of the variables with the list returned to Lisp should have shown the problem very clearly.