Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109223: Utility function to make a list from specified amount of objects.

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 27 Jul 2012 11:56:19 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Cc: emacs-diffs@gnu.org, Emacs development discussions <emacs-devel@gnu.org>
> 
> On 07/27/2012 10:45 AM, martin rudalics wrote:
> 
> > revno: 109223
> > committer: Dmitry Antipov <address@hidden>
> > branch nick: trunk
> > timestamp: Fri 2012-07-27 10:04:35 +0400
> > message:
> >    Utility function to make a list from specified amount of objects.
> >    * lisp.h (enum constype): New datatype.
> >    (listn): New prototype.
> >    * alloc.c (listn): New function.
> >    (Fmemory_use_count, syms_of_alloc): Use it.
> >    * buffer.c (syms_of_buffer): Likewise.
> >    * callint.c (syms_of_callint): Likewise.
> >    * charset.c (define_charset_internal): Likewise.
> >    * coding.c (syms_of_coding): Likewise.
> >    * keymap.c (syms_of_keymap): Likewise.
> >    * search.c (syms_of_search): Likewise.
> >    * syntax.c (syms_of_syntax): Likewise.
> >    * w32.c (init_environment): Likewise.
> >    * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
> >    * xdisp.c (syms_of_xdisp): Likewise.
> >    * xfns.c (syms_of_xfns): Likewise.
> >
> > gets me
> >
> > w32.c: In function 'init_environment':
> > w32.c:1727:34: error: expected ')' before ';' token
> > make[1]: *** [oo/i386/w32.o] Error 1
> > make[1]: Leaving directory `c:/emacs/trunk/src'
> > make: *** [all-other-dirs-gmake] Error 2

In addition, there was a more serious error in listn: it consed the
arguments in the wrong order: from first to last, instead of the other
way around.  This caused incorrect frame title to be displayed, but
also had other manifestations: e.g., memory-use-counts would display
its results in the reversed order.

(I fixed listn in revision 109230.)

Dmitry, I wonder how you tested listn, that left these problems
undetected.  Just stepping into memory-use-counts with a debugger and
comparing the values of the variables with the list returned to Lisp
should have shown the problem very clearly.