From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12632: file permissions checking mishandled when setuid Date: Tue, 23 Oct 2012 05:47:58 +0200 Message-ID: <836261df2p.fsf@gnu.org> References: <5078CAB6.7020509@cs.ucla.edu> <83fw5h5yo6.fsf@gnu.org> <507B010F.20105@cs.ucla.edu> <831uh06gqd.fsf@gnu.org> <507B15B0.2040802@cs.ucla.edu> <83txtw4xmk.fsf@gnu.org> <507B2354.3030408@cs.ucla.edu> <83sj9g4vy7.fsf@gnu.org> <507BAA6C.2000601@cs.ucla.edu> <83lif74p78.fsf@gnu.org> <507C823D.40304@cs.ucla.edu> <83d30j3wqg.fsf@gnu.org> <507CF802.6000305@cs.ucla.edu> <83a9vm4bmv.fsf@gnu.org> <50818763.80501@cs.ucla.edu> <83wqymz4me.fsf@gnu.org> <5081A1DF.9000009@cs.ucla.edu> <5081ABD6.9060002@cs.ucla.edu> <23r4osd2f9.fsf@fencepost.gnu.org> <50836366.6080600@cs.ucla.edu> <5084E1B2.2020105@cs.ucla.edu> <83ipa2ctl2.fsf@gnu.org> <5085AD9E.7040701@cs.ucla.edu> <838vaycj65.fsf@gnu.org> <5085BB01.2030402@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1350964103 26344 80.91.229.3 (23 Oct 2012 03:48:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2012 03:48:23 +0000 (UTC) Cc: 12632@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 23 05:48:27 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQVTd-0005C2-Al for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2012 05:48:25 +0200 Original-Received: from localhost ([::1]:50018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQVTV-0007Ai-Qi for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 23:48:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQVTS-0007AQ-8g for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:48:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQVTR-0005zN-AH for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:48:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQVTR-0005zH-6x for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:48:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQVVC-00036b-DT for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Oct 2012 03:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 12632-submit@debbugs.gnu.org id=B12632.135096420111926 (code B ref 12632); Tue, 23 Oct 2012 03:50:02 +0000 Original-Received: (at 12632) by debbugs.gnu.org; 23 Oct 2012 03:50:01 +0000 Original-Received: from localhost ([127.0.0.1]:56650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQVVA-00036J-TG for submit@debbugs.gnu.org; Mon, 22 Oct 2012 23:50:01 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:39080) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQVV7-000362-Ue for 12632@debbugs.gnu.org; Mon, 22 Oct 2012 23:49:59 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MCB00000UEJ9900@a-mtaout23.012.net.il> for 12632@debbugs.gnu.org; Tue, 23 Oct 2012 05:48:01 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCB000HKUK06530@a-mtaout23.012.net.il>; Tue, 23 Oct 2012 05:48:01 +0200 (IST) In-reply-to: <5085BB01.2030402@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65899 Archived-At: > Date: Mon, 22 Oct 2012 14:30:41 -0700 > From: Paul Eggert > CC: rgm@gnu.org, 12632@debbugs.gnu.org > > Is it possible in Windows that the searchability of the file named "//" > differs from the searchability of "/"? Or that the searchability > of "\/" differs from that of "\"? Both is true. // or \\ or \/ starts a UNC, and Windows expects the following to be the name of a remote machine. / or \ is just the root directory of the current drive. > Emacs currently assumes that all directories are searchable on > Windows, so any such scenario would break Emacs elsewhere, right? expand-file-name already handles the UNC case. > > Windows file APIs are picky wrt trailing slashes. > > Can you give an example of how that might affect the test? The call to faccessat could fail, just because of the "\/." at the end of the file name. > > We use IS_DIRECTORY_SEP in other places, so why avoid it here? > > If it's not needed, it makes the code a bit harder to read. I disagree.