From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: sds@gnu.org, spinuvit@gmail.com, emacs-devel@gnu.org
Subject: Re: feature request: view part of file
Date: Sat, 19 Jan 2013 15:47:43 +0200 [thread overview]
Message-ID: <83622tqo74.fsf@gnu.org> (raw)
In-Reply-To: <50FA95FE.2090105@cs.ucla.edu>
> Date: Sat, 19 Jan 2013 04:47:58 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: sds@gnu.org, spinuvit@gmail.com, emacs-devel@gnu.org
>
> It's a good idea for a couple of reasons. First, the old code
> mishandled things if the file was renamed by some other process
> between the time that Emacs opened it and the time that
> file-regular-p invoked stat on it. Second, the typical GNU style
> is that the behavior of a program should not depend on the type of
> output device.
>
> I looked at the old change you mentioned, and it appears that
> there was a problem on DOS_NT with invoking lseek (fd, 0, SEEK_END) when
> FD is not a regular file. Here's a patch that should avoid this problem:
Thanks. I think this should go in, with one caveat:
> + open_flags = O_WRONLY | O_BINARY | O_CREAT;
> + open_flags |= EQ (mustbenew, Qexcl) ? O_EXCL : O_TRUNC;
> + if (NUMBERP (append))
> + offset = file_offset (append);
> + else if (!NILP (append))
> + open_flags |= O_APPEND;
We cannot use O_TRUNC if the APPEND argument is non-nil, can we? Or
did I misunderstand something?
next prev parent reply other threads:[~2013-01-19 13:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 20:52 feature request: view part of file Sam Steingold
2012-06-13 23:16 ` Stefan Monnier
2012-06-14 16:20 ` Sam Steingold
2012-06-14 16:53 ` Mathias Dahl
2012-06-14 17:32 ` Stephen J. Turnbull
2012-06-14 18:21 ` Paul Eggert
2012-06-14 18:21 ` bug#8794: " Paul Eggert
[not found] ` <jwvd3517qww.fsf-monnier+emacs@gnu.org>
[not found] ` <CABrcCQ5zDfB2tw9DRrwpCZmDqHPc+BB6W5w9ULNU95e_v4yyJw@mail.gmail.com>
[not found] ` <87395xu768.fsf@gnu.org>
[not found] ` <CABrcCQ6rpG9qhsCO+ZEpTiNqbQRtg-PBeb=q_B5F8YgrGxoWKA@mail.gmail.com>
[not found] ` <jwvvcit67sc.fsf-monnier+emacs@gnu.org>
2012-06-14 19:34 ` Sam Steingold
2012-06-14 21:29 ` Sam Steingold
2012-06-18 20:34 ` Štěpán Němec
2012-07-19 17:58 ` Samuel Bronson
2012-07-19 19:38 ` Stephen J. Turnbull
2012-08-04 11:58 ` Andrey Kotlarski
2013-01-18 23:30 ` Vitalie Spinu
2013-01-18 23:52 ` Vitalie Spinu
2013-01-19 6:54 ` Eli Zaretskii
2013-01-19 10:18 ` Paul Eggert
2013-01-19 10:51 ` Eli Zaretskii
2013-01-19 12:47 ` Paul Eggert
2013-01-19 13:47 ` Eli Zaretskii [this message]
2013-01-19 19:00 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83622tqo74.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=sds@gnu.org \
--cc=spinuvit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.