From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: CHAR_TO_BYTE in bidi_resolve_explicit_1 Date: Tue, 05 Mar 2013 20:14:46 +0200 Message-ID: <8362153e95.fsf@gnu.org> References: <513552F8.40405@yandex.ru> <83vc96sdve.fsf@gnu.org> <5135BB1E.60202@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1362507946 13817 80.91.229.3 (5 Mar 2013 18:25:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Mar 2013 18:25:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 05 19:26:10 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UCwYz-0004j9-Ir for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2013 19:26:09 +0100 Original-Received: from localhost ([::1]:53344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCwYd-0005St-Uv for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2013 13:25:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCwYX-0003EK-Hi for emacs-devel@gnu.org; Tue, 05 Mar 2013 13:25:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCwO7-0006TU-Ir for emacs-devel@gnu.org; Tue, 05 Mar 2013 13:14:56 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:59354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCwO7-0006PF-9t for emacs-devel@gnu.org; Tue, 05 Mar 2013 13:14:55 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MJ700F0090SWV00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Tue, 05 Mar 2013 20:14:52 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJ700FMK9CRPVB0@a-mtaout21.012.net.il>; Tue, 05 Mar 2013 20:14:52 +0200 (IST) In-reply-to: <5135BB1E.60202@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157534 Archived-At: > Date: Tue, 05 Mar 2013 13:30:06 +0400 > From: Dmitry Antipov > CC: emacs-devel@gnu.org > > On 03/05/2013 07:51 AM, Eli Zaretskii wrote: > > > We could use BEGV_BYTE when we limit charpos to BEGV, yes. But > > otherwise, the call to CHAR_TO_BYTE is not redundant, because nothing > > else makes sure bidi_it->charpos is synchronized with bidi_it->bytepos > > when the display engine re-seats the display iterator. > > AFAICS reseat routines uses bidi_init_it to make sure that BIDI stuff > is synced with the rest of redisplay, isn't it? Actually, I see that you are right. I was speaking from my failing memory of a situation that has long since changed. So I installed a slightly more radical change than the one you suggested. Thanks.