From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113221: Implement visual-order cursor motion. Date: Sat, 29 Jun 2013 18:24:29 +0300 Message-ID: <8361wxdjo2.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1372519476 6775 80.91.229.3 (29 Jun 2013 15:24:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Jun 2013 15:24:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 29 17:24:37 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Usx0u-0003r5-3W for ged-emacs-devel@m.gmane.org; Sat, 29 Jun 2013 17:24:36 +0200 Original-Received: from localhost ([::1]:48940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Usx0t-0004TE-NS for ged-emacs-devel@m.gmane.org; Sat, 29 Jun 2013 11:24:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Usx0p-0004T8-M5 for emacs-devel@gnu.org; Sat, 29 Jun 2013 11:24:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Usx0o-0000DA-BL for emacs-devel@gnu.org; Sat, 29 Jun 2013 11:24:31 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:58804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Usx0o-0000Cj-1T for emacs-devel@gnu.org; Sat, 29 Jun 2013 11:24:30 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MP500G00UO28900@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sat, 29 Jun 2013 18:24:28 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MP500GK3USS8F00@a-mtaout23.012.net.il>; Sat, 29 Jun 2013 18:24:28 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161279 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sat, 29 Jun 2013 11:12:34 -0400 > > > + (if (< n 0) > > + (move-point-visually -1) > > + (move-point-visually 1)) > > Aka > (move-point-visually (if (< n 0) -1 1)) Fixed. > > + (sit-for 0)) > > I think this deserves a comment, because I for one have no idea why > it's here. It's probably my misunderstanding of something. If I remove sit-for, invoking the command with N > 1 causes it to see the value of point that is not updated. That is, if point is at position X and you invoke C-u 10 then inside move-point-visually I see on the 2nd or 3rd call that point is being reset back to its value before the first call.