From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Problems with --enable-gcc-warnings Date: Wed, 18 Dec 2013 18:17:49 +0200 Message-ID: <8361qmcevm.fsf@gnu.org> References: <83ppovcqcf.fsf@gnu.org> <52B0B8BF.9020409@cs.ucla.edu> <83fvprchjh.fsf@gnu.org> <52B0CE3D.2060305@cs.ucla.edu> <83eh5addhl.fsf@gnu.org> <52B12107.8020309@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1387383465 23350 80.91.229.3 (18 Dec 2013 16:17:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Dec 2013 16:17:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 18 17:17:50 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VtJoj-0005sM-H9 for ged-emacs-devel@m.gmane.org; Wed, 18 Dec 2013 17:17:49 +0100 Original-Received: from localhost ([::1]:39367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtJoj-0007IP-2H for ged-emacs-devel@m.gmane.org; Wed, 18 Dec 2013 11:17:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtJob-0007II-P1 for emacs-devel@gnu.org; Wed, 18 Dec 2013 11:17:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtJoW-00046a-42 for emacs-devel@gnu.org; Wed, 18 Dec 2013 11:17:41 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:60038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtJoV-00043j-T3 for emacs-devel@gnu.org; Wed, 18 Dec 2013 11:17:36 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MY000E00FWX3L00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 18 Dec 2013 18:17:34 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MY000CGCFX9T6P0@a-mtaout22.012.net.il>; Wed, 18 Dec 2013 18:17:34 +0200 (IST) In-reply-to: <52B12107.8020309@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166589 Archived-At: > Date: Tue, 17 Dec 2013 20:13:59 -0800 > From: Paul Eggert > CC: emacs-devel@gnu.org > > Eli Zaretskii wrote: > >> The 'configure'-time code already does the latter, or tries to -- > > Can you point to that code, please? > > The source is in m4/warnings.m4 and m4/manywarnings.m4. Sorry, I thought there was something else. The reason these tests don't really do the job is clear from config.log: configure:8072: checking whether C compiler handles -Wenum-compare configure:8091: gcc -std=gnu99 -o conftest -O0 -g3 -Wenum-compare -DGLYPH_DEBUG=1 conftest.c >&5 cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but not for C configure:8091: $? = 0 configure:8102: result: yes IOW, the test expects the compiler to fail, but warnings don't fail until you add -Werror to the game. So perhaps the test should use -Werror as well, to ensure such warnings fail the compilation of test programs.