From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17532: 24.4.50; Options > `set-frame-font' does not work as documented Date: Wed, 21 May 2014 19:46:17 +0300 Message-ID: <8361kznkpy.fsf@gnu.org> References: <7f75d016-b170-4502-999a-ab657354e6b2@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1400690909 11478 80.91.229.3 (21 May 2014 16:48:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 May 2014 16:48:29 +0000 (UTC) Cc: 17532@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 21 18:48:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wn9gf-0000cC-Hu for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 May 2014 18:48:17 +0200 Original-Received: from localhost ([::1]:60971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn9gf-0004xB-6I for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 May 2014 12:48:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn9gW-0004pu-8I for bug-gnu-emacs@gnu.org; Wed, 21 May 2014 12:48:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn9gR-000193-1c for bug-gnu-emacs@gnu.org; Wed, 21 May 2014 12:48:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn9gQ-00018y-VV for bug-gnu-emacs@gnu.org; Wed, 21 May 2014 12:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wn9gQ-0002Sj-C3 for bug-gnu-emacs@gnu.org; Wed, 21 May 2014 12:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 May 2014 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17532-submit@debbugs.gnu.org id=B17532.14006908239371 (code B ref 17532); Wed, 21 May 2014 16:48:02 +0000 Original-Received: (at 17532) by debbugs.gnu.org; 21 May 2014 16:47:03 +0000 Original-Received: from localhost ([127.0.0.1]:55523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wn9fS-0002R4-L9 for submit@debbugs.gnu.org; Wed, 21 May 2014 12:47:03 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:32859) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wn9fO-0002QM-2S for 17532@debbugs.gnu.org; Wed, 21 May 2014 12:47:00 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N5X00D00NL0TW00@a-mtaout22.012.net.il> for 17532@debbugs.gnu.org; Wed, 21 May 2014 19:46:07 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5X00DMKNWUIM60@a-mtaout22.012.net.il>; Wed, 21 May 2014 19:46:07 +0300 (IDT) In-reply-to: <7f75d016-b170-4502-999a-ab657354e6b2@default> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89329 Archived-At: > Date: Tue, 20 May 2014 14:00:36 -0700 (PDT) > From: Drew Adams > Cc: 17532@debbugs.gnu.org > > > Then this is expected behavior: selecting a new font from that menu > > only changes the font for the existing frames, not for the future > > ones. > > That's not what the *doc* says. You don't see that stated anywhere, > do you? I do. > And why should that be the case? Not relevant to the documentation issue. (Personally, I think that menu item should have changed the font only on the current frame, but that's water under the bridge.) > And what happens when you "save this for future sessions" (node > Fonts)? Not relevant to the issue (and IMO explained in the doc). > What good could it do, and what meaning could it have, to save > something that is only for existing frames (not new frames) in this > session? Fonts are attributes of faces, and faces are always frame-specific. It is reasonable to give the user a possibility to change the font only of some frames and not others. > > > Anyway, when you use menu item `Set Default Font', it invokes `menu-set-font', > > > which calls `set-frame-font' *non-interactively*, and with `t' as the > > > value for FRAMES. > > > > But that doesn't cover future frames, either. It only affects the > > existing GUI frames, per the doc string (and the code, which see). > ^^^^^^^^^^^^^^^^^^ > > Where are you getting this? `C-h f set-frame-font' says clearly: > > Also, if FRAME is non-nil, alter the user's Customization settings as > though the font-related attributes of the `default' face had been > "set in this session", so that the font is applied to future frames. > > One of us seems to be sorely missing something. ;-) You are missing the previous sentence of the doc string. I have now made it say clearly that only the existing frames are affected. > (That's a typo, BTW: FRAME here should be FRAMES.) Fixed. > > > In addition, the doc string for `menu-set-font' says that it makes the > > > font you choose "the default". It does NOT at all suggest that it changes > > > the font only for the current frame. Similarly, the menu item itself speaks > > > of "Default". > > > > "Default font" means the font of the default face, that's all. Yes, > > that's ambiguous. > > A face, including face `default', is not something that is frame-specific. Faces are _always_ frame-specific in Emacs. That includes the 'default' face. Thus, changing the 'default' face does not imply the change affects all frames, let alone future frames. > > > It likens the behavior of `Set Default Font' to modifying `default-frame- > > > alist'. > > > > No, it doesn't mention default-frame-alist at all. > > It most certainly does - the very next bullet! The very next bullet is about a different method of changing the font, so it's not really relevant to what this first bullet describes. Anyway, I made the changes that clarify the current behavior. The part that seems to say that Customize settings are changed to affect the font change on all future frames does not correspond to what actually happens. This could be a code bug or a documentation bug; someone who can decipher the Customize-related code in set-frame-font will have to look into this, and fix either the doc string or the code as appropriate. For now, I left that part of the doc string unaltered.