From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21999: 25.0.50; Binary with --enable-checking immediately aborts with '0<=size' Date: Wed, 25 Nov 2015 19:34:00 +0200 Message-ID: <83610qx9tj.fsf@gnu.org> References: <87oaekh4s5.fsf@isaac.fritz.box> <83poz0zcsi.fsf@gnu.org> <87poyzzpph.fsf@secretsauce.net> <83bnajz88k.fsf@gnu.org> <565568D9.2010005@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448472937 30537 80.91.229.3 (25 Nov 2015 17:35:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Nov 2015 17:35:37 +0000 (UTC) Cc: 21999@debbugs.gnu.org, dima@secretsauce.net, deng@randomsample.de To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 25 18:35:25 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1dyH-0007jW-T8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2015 18:35:10 +0100 Original-Received: from localhost ([::1]:46878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dyJ-0004yz-JZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2015 12:35:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dyF-0004xE-EH for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 12:35:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1dyA-0003iy-LV for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 12:35:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dyA-0003ir-I8 for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 12:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a1dyA-0003X0-4i for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 12:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2015 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21999-submit@debbugs.gnu.org id=B21999.144847286913527 (code B ref 21999); Wed, 25 Nov 2015 17:35:01 +0000 Original-Received: (at 21999) by debbugs.gnu.org; 25 Nov 2015 17:34:29 +0000 Original-Received: from localhost ([127.0.0.1]:53038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1dxd-0003W6-0A for submit@debbugs.gnu.org; Wed, 25 Nov 2015 12:34:29 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:39366) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1dxH-0003VU-NX for 21999@debbugs.gnu.org; Wed, 25 Nov 2015 12:34:26 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NYD00I00SMJ4Y00@a-mtaout22.012.net.il> for 21999@debbugs.gnu.org; Wed, 25 Nov 2015 19:34:06 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYD00HZ0SSSXO60@a-mtaout22.012.net.il>; Wed, 25 Nov 2015 19:34:04 +0200 (IST) In-reply-to: <565568D9.2010005@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109241 Archived-At: > Cc: deng@randomsample.de, 21999@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 24 Nov 2015 23:52:57 -0800 > > Eli Zaretskii wrote: > > After all, the size field of the pseudo-vector object is not > > really a size, but a bunch of bitfields, so I'm not sure testing it in > > its entirety makes sense. Paul? > > The point of the eassume is that it improves code quality in the common case > where the size field is actually a size, since the compiler can generate better > code when it knows that sizes are nonnegative. Also, it should improve checking > a bit, in case someone trashes a size field. > > Looks like this is more trouble than it's worth, and we should get rid of that > eassume, at least in emacs-25. Or have you fixed it? I fixed this particular issue, which happened because several macros on font.h used ASIZE and were called in the context of GC. Now each such macro has a GC_* variant that calls gc_asize instead. If that's a clean enough solution, we can safely move on. I was just worried that ASIZE is no longer safe in GC, and any macro that uses it becomes unsafe. But currently, any such remaining macros aren't called by GC code, so there are no more known problems, just a subtlety.