From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 build broken? Date: Thu, 24 Dec 2015 19:01:16 +0200 Message-ID: <8360znok6b.fsf@gnu.org> References: <567AA6FE.1060905@alice.it> <83k2o5p1sa.fsf@gnu.org> <567AD644.5000702@alice.it> <567B375D.30708@alice.it> <567B51D0.3010601@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1450976491 24739 80.91.229.3 (24 Dec 2015 17:01:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Dec 2015 17:01:31 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org, angelo.graziosi@alice.it, kaushal.modi@gmail.com To: Anders Lindgren Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 24 18:01:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aC9GX-0000ED-To for ged-emacs-devel@m.gmane.org; Thu, 24 Dec 2015 18:01:26 +0100 Original-Received: from localhost ([::1]:60962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC9GW-0003eI-Qw for ged-emacs-devel@m.gmane.org; Thu, 24 Dec 2015 12:01:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC9Ft-00039s-5X for emacs-devel@gnu.org; Thu, 24 Dec 2015 12:00:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aC9Fs-0003TF-6v for emacs-devel@gnu.org; Thu, 24 Dec 2015 12:00:45 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC9Fn-0003S5-6x; Thu, 24 Dec 2015 12:00:39 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3081 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aC9Fl-0003RW-Ip; Thu, 24 Dec 2015 12:00:38 -0500 In-reply-to: (message from Anders Lindgren on Thu, 24 Dec 2015 10:06:00 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196770 Archived-At: > Date: Thu, 24 Dec 2015 10:06:00 +0100 > From: Anders Lindgren > Cc: Kaushal Modi , > Emacs developers , > Angelo Graziosi > > The commit has been reverted. Sorry about the inconvenience. Thanks, Anders. For the future, there's no need to revert a commit, unless it's clear that there's a bug in the commit itself. In your case, the commit is correct and bug-free, and it fixes a real problem. In such cases, the way to fix any fallout is to find the new problem exposed by the commit and fix that new problem. If people are annoyed by the temporary breakage of the branch, they can always reset their HEAD to a prior commit, until the problem is fixed. They can even try debugging the new problem and fixing it ;-) Anyway, I found the reason for these weird messages. It was a subtle issue with the code in ucs-normalize.el that was always there, and was simply exposed by promoting it to be compiled by bootstrap-emacs earlier in the bootstrap process. So please revert the revert, and I will follow up with the changes that fix the broken bootstrap. Thanks.