all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Anders Lindgren <andlind@gmail.com>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org,
	angelo.graziosi@alice.it, kaushal.modi@gmail.com
Subject: Re: emacs-25 build broken?
Date: Thu, 24 Dec 2015 19:01:16 +0200	[thread overview]
Message-ID: <8360znok6b.fsf@gnu.org> (raw)
In-Reply-To: <CABr8ebaim-FEBPEUBKZvMHztzwokKizZLP8iEqAMBLAGHSnCSA@mail.gmail.com> (message from Anders Lindgren on Thu, 24 Dec 2015 10:06:00 +0100)

> Date: Thu, 24 Dec 2015 10:06:00 +0100
> From: Anders Lindgren <andlind@gmail.com>
> Cc: Kaushal Modi <kaushal.modi@gmail.com>,
> 	Emacs developers <emacs-devel@gnu.org>,
> 	Angelo Graziosi <angelo.graziosi@alice.it>
> 
> The commit has been reverted. Sorry about the inconvenience.

Thanks, Anders.

For the future, there's no need to revert a commit, unless it's clear
that there's a bug in the commit itself.  In your case, the commit is
correct and bug-free, and it fixes a real problem.  In such cases, the
way to fix any fallout is to find the new problem exposed by the
commit and fix that new problem.  If people are annoyed by the
temporary breakage of the branch, they can always reset their HEAD to
a prior commit, until the problem is fixed.  They can even try
debugging the new problem and fixing it ;-)

Anyway, I found the reason for these weird messages.  It was a subtle
issue with the code in ucs-normalize.el that was always there, and was
simply exposed by promoting it to be compiled by bootstrap-emacs
earlier in the bootstrap process.

So please revert the revert, and I will follow up with the changes
that fix the broken bootstrap.

Thanks.



  reply	other threads:[~2015-12-24 17:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 13:51 emacs-25 build broken? Angelo Graziosi
2015-12-23 15:22 ` Kaushal Modi
2015-12-23 16:31   ` Eli Zaretskii
2015-12-23 16:28 ` Eli Zaretskii
2015-12-23 17:13   ` Angelo Graziosi
2015-12-23 17:17     ` Kaushal Modi
2015-12-23 18:27       ` Anders Lindgren
2015-12-23 22:47         ` Angelo Graziosi
2015-12-23 23:44           ` Herbert J. Skuhra
2015-12-24  0:07         ` Angelo Graziosi
2015-12-24  2:00           ` Paul Eggert
2015-12-24  8:45             ` Anders Lindgren
2015-12-24  9:06               ` Anders Lindgren
2015-12-24 17:01                 ` Eli Zaretskii [this message]
2015-12-24 18:35                   ` Anders Lindgren
2015-12-24 19:19                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8360znok6b.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andlind@gmail.com \
    --cc=angelo.graziosi@alice.it \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.