all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 22557@debbugs.gnu.org
Subject: bug#22557: 25.0.90; Saving a buffer under auto-revert turns off file notifications
Date: Fri, 05 Feb 2016 16:41:59 +0200	[thread overview]
Message-ID: <8360y3uslk.fsf@gnu.org> (raw)
In-Reply-To: <87y4azs5um.fsf@gmx.de> (message from Michael Albinus on Fri, 05 Feb 2016 13:24:01 +0100)

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 22557@debbugs.gnu.org
> Date: Fri, 05 Feb 2016 13:24:01 +0100
> 
> > I don't understand the logic of this: at least with w32notify, when a
> > file is in auto-revert-mode, we watch the entire parent directory of
> > that file, so there's no need to send the 'stopped' event when the
> > file is renamed or deleted, only when the parent directory is deleted.
> 
> In `auto-revert-notify-add-watch', only the file named by
> `buffer-file-name' is watched. autorevert.el does not check, what the
> underlying library of filenotify.el is able to do, watching single files
> or whole directories.

I don't think the problem is in autorevert.el.  The problem is in
filenotify.el, which is where 'stopped' is generated.  Filenotify does
know what it watches.

> And as said, a renaming of a file should not turn file notifications
> off. I will try to fix this.

Neither should deleting a file, IMO.  Otherwise you will lose during
saving, since that's what Emacs does then.

> I really hate it that we have no ChangeLog anymore, maintained by the
> developers.

Maybe we should re-introduce them.  git-merge-changelog makes merging
them all but free of problems, so perhaps we are paying a price that's
too heavy for eliminating ChangeLog.





  reply	other threads:[~2016-02-05 14:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 18:34 bug#22557: 25.0.90; Saving a buffer under auto-revert turns off file notifications Eli Zaretskii
2016-02-05 12:24 ` Michael Albinus
2016-02-05 14:41   ` Eli Zaretskii [this message]
2016-02-05 14:50     ` Michael Albinus
2016-02-07 18:35     ` Michael Albinus
2016-02-07 19:40       ` Eli Zaretskii
2016-02-07 19:56         ` Michael Albinus
2016-02-07 20:32           ` Eli Zaretskii
2016-02-08 10:02             ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8360y3uslk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=22557@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.