From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Thu, 14 Jul 2016 18:15:51 +0300 Message-ID: <8360s88d3s.fsf@gnu.org> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <87twg05nqf.fsf@russet.org.uk> <83a8hla8nx.fsf@gnu.org> <87mvlkigb1.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468510565 23451 80.91.229.3 (14 Jul 2016 15:36:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Jul 2016 15:36:05 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 14 17:35:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNifq-0003hB-HA for ged-emacs-devel@m.gmane.org; Thu, 14 Jul 2016 17:35:38 +0200 Original-Received: from localhost ([::1]:54897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNifp-0003Wi-FY for ged-emacs-devel@m.gmane.org; Thu, 14 Jul 2016 11:35:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNiNF-0007SK-Ci for emacs-devel@gnu.org; Thu, 14 Jul 2016 11:16:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNiNA-0007sm-4o for emacs-devel@gnu.org; Thu, 14 Jul 2016 11:16:24 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNiNA-0007si-1N; Thu, 14 Jul 2016 11:16:20 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1764 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bNiN7-0001Rb-2A; Thu, 14 Jul 2016 11:16:19 -0400 In-reply-to: <87mvlkigb1.fsf@russet.org.uk> (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205677 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Cc: Stefan Monnier , emacs-devel@gnu.org > Date: Thu, 14 Jul 2016 12:56:34 +0100 > > I would suggest not the idea was not to no longer require changelog > format, but to replace it with something else. No one suggested any particular format, the only suggestion was to relax the current requirements, AFAIR. > There are two main problems with ChangeLog format -- first, it's just a > bit of a pain splitting the information into changes associated with > individual functions. Stefan mention the feature of diff-mode, which IMO is very convenient if you run it on the output of "git diff" or something similar. > The second, more substantive issue, is that it focuses the mind too > much on how we have changed things rather than why, at least in my > experience. It's up to us. Just to show you a random example to the contrary: commit fbfd4787fbec11fe69f5e661e7c5ab4436f7cb72 Author: Eli Zaretskii Date: Tue May 24 19:04:16 2016 +0300 Avoid aborting due to errors in arguments of 'set-face-attribute' * src/xfaces.c (Finternal_set_lisp_face_attribute): Check the FRAME argument before using it. This avoids gratuitous aborts in Emacs built with --enable-checking when the luser was unlucky enough to get the argument list in wrong order. You will find quite a few similar examples in Paul's commits, for example.