all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 24085@debbugs.gnu.org
Subject: bug#24085: 25.1.50; `make-frame' given `top' param creates frame with ~10x smaller `top'
Date: Wed, 27 Jul 2016 22:00:33 +0300	[thread overview]
Message-ID: <8360rqsy7i.fsf@gnu.org> (raw)
In-Reply-To: <325b79e8-c40b-46f7-a89a-11f0888b0a68@default> (message from Drew Adams on Wed, 27 Jul 2016 11:39:49 -0700 (PDT))

> Date: Wed, 27 Jul 2016 11:39:49 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: rudalics@gmx.at, 24085@debbugs.gnu.org
> 
> > > > > Would someone please revert this, and let `make-frame' respect the
> > > > > frame parameters handed to it, in particular `top'?
> > > >
> > > > Not a chance, sorry.
> > >
> > > Huh? What's that all about?
> > 
> > Reverting the change will reintroduce the bug it fixed
> 
> Obviously, as I indicated in my earlier message, I meant that the
> bug that it fixed should be fixed properly, without treading on
> `make-frame'.  If on MS Windows you think the first Emacs frame
> should be positioned so that it does not overlap the task bar,
> then do that.  But do it without affecting what `make-frame' does.
> 
> > so doing that is out of the question.
> 
> What _is_ in the question, then?

Anything else.

> If you are unwilling to fix the code, will you fix the doc?

If that's the best we can do, yes.

> Just what bug did this change seek to fix?  Wasn't it only the default,
> initial behavior of Emacs for the initial frame?  If so, how is this
> general change to `make-frame' the right fix for that bug?

Please re-read the discussion, the answers are there.

> And how would it hurt for `make-frame' to at least respect an _explicit_
> frame alist argument, which is, after all, optional?  Why does it have
> such an argument, if it no longer respects it?

The code that bothers you is not in make-frame.

> But why take over the single, general-purpose frame-creation Lisp
> function we have, changing its behavior to ignore parts of optional
> arg PARAMETERS (on one platform, no less), just to accommodate the
> special case of the initial frame?

No one took over any Lisp function.  The code in question is deep in
the low-level support for creating frames on Windows.  What it does is
make sure a frame, any frame, is not displayed with its echo area's
view obstructed by the task bar.

> This makes no sense to me.  And I find it hard to believe that you
> would not consider fixing that bug properly and restoring `make-frame'
> to a general-purpose function that respects whatever optional frame
> parameters are specified.

You put in my mouth things I didn't say.





  reply	other threads:[~2016-07-27 19:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  4:49 bug#24085: 25.1.50; `make-frame' given `top' param creates frame with ~10x smaller `top' Drew Adams
2016-07-27  9:19 ` martin rudalics
2016-07-27 13:29   ` Drew Adams
2016-07-27 16:23     ` Eli Zaretskii
2016-07-28  8:57     ` martin rudalics
2016-07-28 14:50       ` Eli Zaretskii
2016-07-28 19:07         ` martin rudalics
2016-07-28 16:34       ` Drew Adams
2016-07-28 19:07         ` martin rudalics
2022-04-22 13:22           ` Lars Ingebrigtsen
2022-04-22 15:28             ` Drew Adams
     [not found]   ` <<3657859c-03f1-4eca-9a78-a9be0dee6552@default>
     [not found]     ` <<83h9bbrqx5.fsf@gnu.org>
2016-07-27 16:57       ` Drew Adams
2016-07-27 17:37         ` Eli Zaretskii
     [not found]   ` <<<3657859c-03f1-4eca-9a78-a9be0dee6552@default>
     [not found]     ` <<<83h9bbrqx5.fsf@gnu.org>
     [not found]       ` <<06a3fb2a-b975-41cf-8aa3-c2cbe207057f@default>
     [not found]         ` <<838twnrngr.fsf@gnu.org>
2016-07-27 18:39           ` Drew Adams
2016-07-27 19:00             ` Eli Zaretskii [this message]
     [not found]   ` <<<<3657859c-03f1-4eca-9a78-a9be0dee6552@default>
     [not found]     ` <<<<83h9bbrqx5.fsf@gnu.org>
     [not found]       ` <<<06a3fb2a-b975-41cf-8aa3-c2cbe207057f@default>
     [not found]         ` <<<838twnrngr.fsf@gnu.org>
     [not found]           ` <<325b79e8-c40b-46f7-a89a-11f0888b0a68@default>
     [not found]             ` <<8360rqsy7i.fsf@gnu.org>
2016-07-27 20:55               ` Drew Adams
2016-07-28  2:12                 ` Clément Pit--Claudel
2016-07-28 16:35                   ` Drew Adams
2016-07-28  8:57                 ` martin rudalics
2016-07-28 16:35                   ` Drew Adams
2016-07-28 14:40                 ` Eli Zaretskii
     [not found]   ` <<<<<3657859c-03f1-4eca-9a78-a9be0dee6552@default>
     [not found]     ` <<<<<83h9bbrqx5.fsf@gnu.org>
     [not found]       ` <<<<06a3fb2a-b975-41cf-8aa3-c2cbe207057f@default>
     [not found]         ` <<<<838twnrngr.fsf@gnu.org>
     [not found]           ` <<<325b79e8-c40b-46f7-a89a-11f0888b0a68@default>
     [not found]             ` <<<8360rqsy7i.fsf@gnu.org>
     [not found]               ` <<6336b8b4-49c0-4ce6-9044-cf558f12c16e@default>
     [not found]                 ` <<8337mtsu54.fsf@gnu.org>
2016-07-28 16:36                   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8360rqsy7i.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24085@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.