From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24041: 25.1.50; xwidget + -nw mode gives segfault Date: Sun, 21 Aug 2016 05:40:20 +0300 Message-ID: <8360qudeuj.fsf@gnu.org> References: <8760qwtxld.fsf@cochranmail.com> <83oa4ndhfw.fsf@gnu.org> <87lgzrm8ft.fsf@cochranmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1471747281 1612 195.159.176.226 (21 Aug 2016 02:41:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Aug 2016 02:41:21 +0000 (UTC) Cc: shanemhansen@gmail.com, 24041@debbugs.gnu.org To: Robert Cochran Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 21 04:41:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbIhI-00008s-DA for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Aug 2016 04:41:16 +0200 Original-Received: from localhost ([::1]:35130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbIhF-0006KP-Iq for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Aug 2016 22:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbIh9-0006KJ-BB for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 22:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbIh4-0003yv-JZ for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 22:41:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbIh4-0003yn-G3 for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 22:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bbIh4-0001Dp-74 for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2016 22:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2016 02:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24041 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24041-submit@debbugs.gnu.org id=B24041.14717472234643 (code B ref 24041); Sun, 21 Aug 2016 02:41:02 +0000 Original-Received: (at 24041) by debbugs.gnu.org; 21 Aug 2016 02:40:23 +0000 Original-Received: from localhost ([127.0.0.1]:35454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbIgR-0001Co-GM for submit@debbugs.gnu.org; Sat, 20 Aug 2016 22:40:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbIgP-0001Cc-Pz for 24041@debbugs.gnu.org; Sat, 20 Aug 2016 22:40:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbIgF-0003p4-O6 for 24041@debbugs.gnu.org; Sat, 20 Aug 2016 22:40:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbIgF-0003oi-Ky; Sat, 20 Aug 2016 22:40:11 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2645 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bbIgD-0000BT-PC; Sat, 20 Aug 2016 22:40:10 -0400 In-reply-to: <87lgzrm8ft.fsf@cochranmail.com> (message from Robert Cochran on Sat, 20 Aug 2016 14:33:58 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122443 Archived-At: > From: Robert Cochran > Cc: Robert Cochran , shanemhansen@gmail.com, 24041@debbugs.gnu.org > Date: Sat, 20 Aug 2016 14:33:58 -0700 > > Eli Zaretskii writes: > > >> From: Robert Cochran > >> Date: Fri, 19 Aug 2016 11:36:30 -0700 > >> Cc: 24041@debbugs.gnu.org > >> > >> Anyways, so the fix here is conceptually pretty simple: have a check in > >> place to ensure (display-graphic-p) returns non-nil before doing any > >> xwidgets stuff. Easy enough. > > > > display-graphic-p accepts argument, so if a function displays on > > another frame or display, it should be passed that frame or display. > > I guess I don't quite understand what you're trying to say here. I'm saying that display-graphic-p should be told the frame for which you are asking the question. > (Is that even possible? Start a graphical frame from a tty Emacs?) Of course, it is. emacsclient can do that. Assuming Emacs was built with GUI support, of course. We have this feature for several years now. > > IMO, the check should be on the C level where the xwidget primitives > > are implemented. One such place is make-xwidget; maybe there are > > more. (The proper way of testing this on the C level is not by > > calling display-graphic-p, but rather with check_x_display_info.) > > That's what my feeling was too. I'll go ahead and do it on the C level > then. Thanks.