From: Eli Zaretskii <eliz@gnu.org>
To: Alain Schneble <a.s@realize.ch>
Cc: toke@toke.dk, emacs-devel@gnu.org, monnier@iro.umontreal.ca,
dgutov@yandex.ru
Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.
Date: Fri, 09 Sep 2016 18:04:19 +0300 [thread overview]
Message-ID: <8360q5868c.fsf@gnu.org> (raw)
In-Reply-To: <86sht9qfyh.fsf@realize.ch> (message from Alain Schneble on Fri, 9 Sep 2016 16:56:54 +0200)
> From: Alain Schneble <a.s@realize.ch>
> CC: Dmitry Gutov <dgutov@yandex.ru>, Eli Zaretskii <eliz@gnu.org>,
> <monnier@iro.umontreal.ca>, <emacs-devel@gnu.org>
> Date: Fri, 9 Sep 2016 16:56:54 +0200
>
> > (url-retrieve-synchronously "http://google.se") ; sets a cookie
> > (let* ((url-request-data (encode-coding-string "æøå" 'utf-8)))
> > (url-retrieve-synchronously "http://google.se")) ; crashes
>
> I was able to reproduce it but am a bit confused, since it doesn't
> signal an error when message-body "æøå" is replaced by "abc", while
> reusing the same cookie.
>
> I tried to track it down with the following example. `cookie-val' is the
> value of the cookie-string:
>
> (string-bytes cookie-val)
> => 131
> (string-bytes (encode-coding-string "æøå" 'utf-8))
> => 6
> (string-bytes (concat (encode-coding-string "æøå" 'utf-8) cookie-val))
> => 143 ' why?
> (string-bytes (concat (string-as-unibyte "abc") ans-cookie-val))
> => 134
Because a multibyte string with ASCII-only text has the same number of
bytes as it has characters. While a multibyte string with non-ASCII
text has more bytes than characters, due to the way Emacs represents
characters internally (which is actually a superset of UTF-8).
> Why does concat behave that strangely? What am I missing here? Is the
> behavior of concatenating a unibyte and a multibyte string simply
> undefined?
No, it isn't undefined. When some of the arguments are multibyte
strings, concat returns a multibyte string. Nothing else would make
sense.
next prev parent reply other threads:[~2016-09-09 15:04 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 15:30 [PATCH] url: Wrap cookie headers in url-http--encode-string Toke Høiland-Jørgensen
2016-09-07 16:40 ` Stefan Monnier
2016-09-07 16:52 ` Toke Høiland-Jørgensen
2016-09-07 17:15 ` Eli Zaretskii
2016-09-07 18:25 ` Toke Høiland-Jørgensen
2016-09-08 14:06 ` Dmitry Gutov
2016-09-08 14:14 ` Toke Høiland-Jørgensen
2016-09-08 14:25 ` Dmitry Gutov
2016-09-08 15:58 ` Toke Høiland-Jørgensen
2016-09-08 17:20 ` Eli Zaretskii
2016-09-08 17:43 ` Toke Høiland-Jørgensen
2016-09-08 18:01 ` Eli Zaretskii
2016-09-08 17:47 ` Stefan Monnier
2016-09-08 18:04 ` Eli Zaretskii
2016-09-08 20:29 ` Alain Schneble
2016-09-09 7:57 ` Eli Zaretskii
2016-09-09 14:56 ` Alain Schneble
2016-09-09 15:04 ` Eli Zaretskii [this message]
2016-09-09 15:16 ` Alain Schneble
2016-09-09 15:06 ` Stefan Monnier
2016-09-09 15:15 ` Alain Schneble
2016-09-09 18:02 ` Alain Schneble
2016-09-09 18:07 ` Toke Høiland-Jørgensen
2016-09-09 18:54 ` Eli Zaretskii
2016-09-09 19:21 ` Alain Schneble
2016-09-09 19:32 ` Eli Zaretskii
2016-09-09 19:47 ` Alain Schneble
2016-09-09 19:49 ` Eli Zaretskii
2016-09-09 19:56 ` Toke Høiland-Jørgensen
2016-09-10 5:42 ` Eli Zaretskii
2016-09-10 8:34 ` Dmitry Gutov
2016-09-10 19:12 ` Eli Zaretskii
2016-09-09 20:01 ` distinguishing multibyte/unibyte ASCII (was: [PATCH] url: Wrap cookie headers in url-http--encode-string.) Stefan Monnier
2016-09-09 20:17 ` distinguishing multibyte/unibyte ASCII Toke Høiland-Jørgensen
2016-09-09 20:46 ` Stefan Monnier
2016-09-09 21:02 ` Alain Schneble
2016-09-10 5:50 ` distinguishing multibyte/unibyte ASCII (was: [PATCH] url: Wrap cookie headers in url-http--encode-string.) Eli Zaretskii
2016-09-07 19:14 ` [PATCH] url: Wrap cookie headers in url-http--encode-string Lars Ingebrigtsen
2016-09-07 20:49 ` Toke Høiland-Jørgensen
2016-09-08 2:47 ` Eli Zaretskii
2016-09-08 9:07 ` Lars Ingebrigtsen
2016-09-08 17:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360q5868c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=a.s@realize.ch \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.