From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions
Date: Mon, 24 Oct 2016 19:07:50 +0300 [thread overview]
Message-ID: <8360oh4tnt.fsf@gnu.org> (raw)
In-Reply-To: <jwvy41detqq.fsf-monnier+gmane.emacs.devel@gnu.org> (message from Stefan Monnier on Mon, 24 Oct 2016 09:56:59 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 24 Oct 2016 09:56:59 -0400
>
> > I think we should consider these nits when we finish fixing the bugs
> > due to relocation,
>
> I think we should not fix those. The constraints imposed by
> a relocating malloc are too difficult to abide to IMO, so we should just
> say no.
It depends on how hard that is. The last one I fixed was very easy.
The only one left I'm aware of is in boyer_moore, which shouldn't be
hard to fix, either.
More generally, as long as even a single platform we care about uses
ralloc.c, I don't think we can leave those problems unfixed, because
their effects are so nasty.
next prev parent reply other threads:[~2016-10-24 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161023191028.10942.12099@vcs.savannah.gnu.org>
[not found] ` <20161023191028.C103F220124@vcs.savannah.gnu.org>
2016-10-23 20:31 ` [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions Stefan Monnier
2016-10-24 6:25 ` Eli Zaretskii
2016-10-24 13:56 ` Stefan Monnier
2016-10-24 16:07 ` Eli Zaretskii [this message]
2016-10-24 19:01 ` Stefan Monnier
2016-10-24 19:46 ` Eli Zaretskii
2016-10-25 12:20 ` Stefan Monnier
2016-10-25 16:22 ` Eli Zaretskii
2016-10-25 19:32 ` Stefan Monnier
2016-10-25 19:40 ` Eli Zaretskii
2016-10-25 19:59 ` Stefan Monnier
2016-10-26 2:29 ` Eli Zaretskii
2016-10-24 14:18 ` Stefan Monnier
2016-10-24 15:35 ` Eli Zaretskii
2016-11-04 8:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360oh4tnt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.